Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comment lines in Mocha options file #3370

Closed
1 task done
plroebuck opened this issue May 3, 2018 · 0 comments
Closed
1 task done

Add support for comment lines in Mocha options file #3370

plroebuck opened this issue May 3, 2018 · 0 comments
Labels
area: usability concerning user experience or interface good first issue new contributors should look here! nice to have enhancement proposal of low priority

Comments

@plroebuck
Copy link
Contributor

plroebuck commented May 3, 2018

Prerequisites

Related proposals:
#2587
#2870
#2963

Description

Add support for Beginning-of-Line (BOL) comments to "mocha.opts". As the file has far more in common with shell scripts (as it contains various Mocha cmdline arguments) than JavaScript tests, the comment character would be the hash ('#') character. Inline comments will not be supported.

Rationale

No current support for comment lines exists for "mocha.opts". With other related upcoming proposals for processing this file, the ability to document this file becomes more important than ever. Believe the other proposals got bogged down trying to do too much, arguing over more advanced features rather than providing the basics. As Larry would say, "Git 'Er Done".

@outsideris outsideris added nice to have enhancement proposal of low priority area: usability concerning user experience or interface good first issue new contributors should look here! labels May 3, 2018
plroebuck added a commit to plroebuck/mocha that referenced this issue May 3, 2018
Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts"
prior to processing its contents.

Fixes mochajs#3370
Bamieh pushed a commit that referenced this issue May 8, 2018
Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts"
prior to processing its contents.

Fixes #3370
boneskull pushed a commit that referenced this issue May 18, 2018
Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts"
prior to processing its contents.

Fixes #3370
sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019
Modified code to strip comment lines, those beginning with a hash character ('#'), from "mocha.opts"
prior to processing its contents.

Fixes mochajs#3370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: usability concerning user experience or interface good first issue new contributors should look here! nice to have enhancement proposal of low priority
Projects
None yet
Development

No branches or pull requests

2 participants