[18.09 backport] Only update non-terminal tasks on node removal #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
When a node is removed, its tasks are set in state ORPHANED. This does not need to be done for tasks that are already in a terminal state, and if all tasks in all states are updated, the size of the transaction may grow too large to process, and node removal becomes impossible. This changes to only set non-terminal tasks to state ORPHANED, and terminal tasks are left alone. Signed-off-by: Drew Erny <drew.erny@docker.com> (cherry picked from commit d5df265) Signed-off-by: Dani Louca <dani.louca@docker.com>
dani-docker
force-pushed
the
bp_18.09_2867
branch
from
49a9b89 to
24f6229
Compare
dani-docker
changed the title
thaJeztah
changed the title
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Aug 8, 2019
full diff: moby/swarmkit@19e791f...142a737 included: - moby/swarmkit#2872 [19.03 backport] Only update non-terminal tasks on node removal - backport of moby/swarmkit#2867 Only update non-terminal tasks on node removal Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Aug 9, 2019
full diff: moby/swarmkit@19e791f...142a737 included: - moby/swarmkit#2872 [19.03 backport] Only update non-terminal tasks on node removal - backport of moby/swarmkit#2867 Only update non-terminal tasks on node removal Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 7fcfdbaab6d8c6a2d55ad7b72a851c5e92b360ac Component: engine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2867
cc: @thaJeztah @dperny
Only update non-terminal tasks on node removal.
- What I did
- How I did it
- How to test it
- Description for the changelog