[18.09 backport] Return correct error-codes on conflicting names #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2061af7) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## bump_v18.09 #2788 +/- ##
===============================================
- Coverage 61.76% 61.68% -0.09%
===============================================
Files 134 134
Lines 21862 21868 +6
===============================================
- Hits 13503 13489 -14
- Misses 6905 6917 +12
- Partials 1454 1462 +8 |
|
Looks solid to me. Passes CI. Small enough change + is a backport. I'm merging solo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2779 for 18.09
cherry-pick was clean; no conflict