[controlapi] Redact the cluster spec CA signing certificate when getting the cluster info #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er info, because otherwise getting and updating would be problematic because the key is redacted but the cert is not. Signed-off-by: Ying Li <ying.li@docker.com>
|
LGTM ping @diogomonica |
Codecov Report
@@ Coverage Diff @@
## master #2263 +/- ##
=========================================
+ Coverage 60.49% 60.5% +0.01%
=========================================
Files 125 125
Lines 20390 20391 +1
=========================================
+ Hits 12334 12337 +3
- Misses 6658 6668 +10
+ Partials 1398 1386 -12 |
This was referenced Jun 16, 2017
6 tasks
tiborvass
pushed a commit
to tiborvass/docker-ce
that referenced
this pull request
Jun 20, 2017
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Feb 3, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 10, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 23, 2020
Brings in these pull requests: - moby/swarmkit#2224 - moby/swarmkit#2268 - moby/swarmkit#2263 Signed-off-by: Tibor Vass <tibor@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not because it's a secret, but otherwise the user flow of getting and updating the cluster spec would be problematic because the key is redacted but the cert is not - the user would be responsible for having to remove the cert instead to make sure this doesn't change the swarm CA key.
cc @aaronlehmann @andrewhsu @jlhawn