[ca] When rotating the root CA, ignore the node membership #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyli
force-pushed
the
root-rotation-also-waits-for-pending-nodes
branch
from
b2cf0f7 to
1d6f6d2
Compare
…p status to rotate as well, because the membership status isn't really used atm, and it is valid for a node update to change the membership status to pending by accident. Also attempt to stabilize some of the root rotation tests. Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
root-rotation-also-waits-for-pending-nodes
branch
from
1d6f6d2 to
aaea568
Compare
Codecov Report
@@ Coverage Diff @@
## master #2218 +/- ##
==========================================
- Coverage 60.4% 60.19% -0.21%
==========================================
Files 124 124
Lines 20149 20149
==========================================
- Hits 12171 12129 -42
- Misses 6620 6659 +39
- Partials 1358 1361 +3 |
|
LGTM |
40 tasks
This was referenced Jun 8, 2017
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2218 - moby/swarmkit#2215 - moby/swarmkit#2233 Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Feb 3, 2020
- moby/swarmkit#2218 - moby/swarmkit#2215 - moby/swarmkit#2233 Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 10, 2020
- moby/swarmkit#2218 - moby/swarmkit#2215 - moby/swarmkit#2233 Signed-off-by: Ying <ying.li@docker.com>
silvin-lubecki
pushed a commit
to silvin-lubecki/engine-extract
that referenced
this pull request
Mar 23, 2020
- moby/swarmkit#2218 - moby/swarmkit#2215 - moby/swarmkit#2233 Signed-off-by: Ying <ying.li@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rotating the root CA, tell nodes that are in "pending" membership status
to rotate as well, because the membership status isn't really used atm, and it
is valid for a node update to change the membership status to pending by
accident.
Also attempt to stabilize some of the root rotation tests. (I think this fixes #2138)
cc @aaronlehmann @diogomonica
moby/mobydoes not set theNodeSpec.Membership, so whenever there's a node update, the membership status gets set toPENDINGwhich is the default value.