Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13.1] Cherry-Pick [#1875]: Fix issue in service update of published ports in host mode #1910

Merged
merged 2 commits into from
Jan 30, 2017
Merged

[v1.13.1] Cherry-Pick [#1875]: Fix issue in service update of published ports in host mode #1910

merged 2 commits into from
Jan 30, 2017

Commits on Jan 30, 2017

  1. Fix issue in service update of published ports in host mode 

    This fix tries to fix the issue in docker/docker/30199
where service update will not work when published ports is
host publish mode.

The reason for the issue is that `isPortsAllocated()`
does not capture host publish mode.

This fix address the issue by updating allocated ports if
there is any change in ports of host (non ingress) mode as well.

Unit tests have been added.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    c2ea56d View commit details
    Browse the repository at this point in the history

  2. Add allocatedPorts definition for cherry-pick 

    This commit adds the `allocatedPorts` for cherry-pick.
The `allocatedPorts` was added in PR moby#1835, which is
not part of the v1.13.1 cherry pick.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
    @yongtang
    yongtang committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    fc8a232 View commit details
    Browse the repository at this point in the history