-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
info: remove "expected" check for tini version #42776
Conversation
These checks were added when we required a specific version of containerd and runc (different versions were known to be incompatible). I don't think we had a similar requirement for tini, so this check was redundant. Let's remove the check altogether. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
v.RuncCommit.ID = "N/A" | ||
v.ContainerdCommit.ID = "N/A" | ||
v.InitCommit.ID = "N/A" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit on the fence if we need to keep the N/A
value on the server-side, or if we should move this to the cli. I'd love to move it there, but will have to think if there could be a breaking change because of that.
I might still do so in a follow-up though 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; too bad we can't drop the Expected
fields altogether 😅
maybe we can. I want to have a look at that. At least check if we can set them to an empty string (which wouldn't return it in the response I guess). If that doesn't break older clients, we could drop them. |
Answering myself; I guess we can't remove them if we have a version, and only if we don't have a version (the N/A case). We could drop the based on API version though (omit them on API >= 1.42) 🤔 |
These checks were added when we required a specific version of containerd
and runc (different versions were known to be incompatible). I don't think
we had a similar requirement for tini, so this check was redundant. Let's
remove the check altogether.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)