libnetwork/ipamutils: various cleanups and refactor #42509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
status/2-code-review
area/networking
kind/refactor
thaJeztah
force-pushed
the
ipamutils_cleanup
branch
from
8d7dcd5 to
78534b0
Compare
thaJeztah
force-pushed
the
ipamutils_cleanup
branch
from
78534b0 to
9d2a42f
Compare
thaJeztah
force-pushed
the
ipamutils_cleanup
branch
from
9d2a42f to
3b5cf10
Compare
thaJeztah
force-pushed
the
ipamutils_cleanup
branch
from
3b5cf10 to
e6b340c
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The `GetLocalScopeDefaultNetworks()` and `GetGlobalScopeDefaultNetworks()` protect these variables with a lock, but various parts in the code were directly accessing the variables without locks. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This package defines the `NetworkToSplit` type. Curently importing the package also initializes the default address pools (which may not be needed, e.g., when used in the client. This patch changes initialization to happen on first use, instead of `init()`, to allow the package to be imported without initializing these pools. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
ipamutils_cleanup
branch
from
e6b340c to
fa3393d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from moby/libnetwork#2593
closes moby/libnetwork#2593
Created using:
curl -fsSL https://patch-diff.githubusercontent.com/raw/moby/libnetwork/pull/2593.patch | git am --3way -S --directory=libnetworkThe
GetLocalScopeDefaultNetworks()andGetGlobalScopeDefaultNetworks()protect these variables with a lock, but various parts in the code were directly accessing the variables without locks.This package defines the
NetworkToSplittype. Curently importing the package also initializes the default address pools (which may not be needed, e.g., when used in the client.This patch changes initialization to happen on first use, instead of
init(), to allow the package to be imported without initializing these pools.