-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API version to v1.40 #38089
Update API version to v1.40 #38089
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This feature was added in 14da20f, and was merged after API v1.39 shipped as part of the Docker 18.09 release candidates. This commit moves the feature to the correct API version. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This feature was added in 514ce73, and was merged after API v1.39 shipped as part of the Docker 18.09 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ping @AkihiroSuda (sorry, this will conflict with #38003) @vdemeester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Windows RS5 seems to be really broken;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yeah, let's merge; the RS5 issue is definitely not related |
Some features were merged after API v1.39 shipped as part of the Docker 18.09 betas; this PR updates the API version to 1.40, and corrects the minimal API version for those features.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
image: "Cute Owl by HELMUTTT"