Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancelling builder on chunked requests #33363

Merged
merged 1 commit into from
May 31, 2017
Merged

Fix cancelling builder on chunked requests #33363

merged 1 commit into from
May 31, 2017

Conversation

tonistiigi
Copy link
Member

fixes #32417

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@tonistiigi
Fix cancelling builder on chunked requests
23628bd 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@vieux
Copy link
Contributor

vieux commented May 31, 2017

LGTM, should probably be cherry-picked in 17.06.x ? /cc @mlaventure

vdemeester
vdemeester approved these changes May 31, 2017
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah
Copy link
Member

@vieux it was reported with 17.03, so not new, and IIUC when directly using the API #32417, to probably not critical, more "good to have"

@thaJeztah
Copy link
Member

all green 💚

@thaJeztah thaJeztah merged commit 7ea0d1e into moby:master May 31, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone May 31, 2017
@thaJeztah thaJeztah mentioned this pull request May 31, 2017
Closed
23 tasks
@thaJeztah thaJeztah mentioned this pull request Jun 7, 2017
Closed
40 tasks
@seemethere seemethere mentioned this pull request Jun 10, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
process/cherry-picked status/2-code-review
Projects
None yet
Milestone
17.06.0
Development

Successfully merging this pull request may close these issues.

Build keeps running after an api connection have been closed
5 participants
@tonistiigi @vieux @thaJeztah @vdemeester @GordonTheTurtle