add d_type warning to docker info, and optimize output #31290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overlay(2) drivers were moved up in the list of storage drivers, and are known to have problems if the backing filesystem does not support d_type. Commit 2e20e63 added a warning, which is logged in the daemon logs, however, many users do not check those logs, and may overlook this warning. This patch adds the same warning to the output of `docker info` so that the warning is more easily found. In addition, the output of warnings printed by `docker info` is optimized, by; - moving all warnings to the _end_ of the output, instead of mixing them with the regular output - wrapping the storage-driver warnings, so that they are more easily readable Example output with this patch applied ============================================ devicemapper using loopback devices: ... Insecure Registries: 127.0.0.0/8 Live Restore Enabled: false WARNING: devicemapper: usage of loopback devices is strongly discouraged for production use. Use `--storage-opt dm.thinpooldev` to specify a custom block storage device. WARNING: bridge-nf-call-iptables is disabled WARNING: bridge-nf-call-ip6tables is disabled overlay2 on xfs without d_type support; ... Insecure Registries: 127.0.0.0/8 Live Restore Enabled: false WARNING: overlay2: the backing xfs filesystem is formatted without d_type support, which leads to incorrect behavior. Reformat the filesystem with ftype=1 to enable d_type support. Running without d_type support will not be supported in future releases. WARNING: bridge-nf-call-iptables is disabled Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Feb 23, 2017
| fmt.Fprintln(dockerCli.Err(), "WARNING: bridge-nf-call-iptables is disabled") | ||
| } | ||
| if !info.BridgeNfIP6tables { | ||
| fmt.Fprintln(dockerCli.Err(), "WARNING: bridge-nf-call-ip6tables is disabled") |
There was a problem hiding this comment.
FWIW, I'm thinking of moving generating these warnings on the daemon side, and return them through the API. Doing so allows API clients to make use of these warnings, and also have each platform (windows, linux) to return platform-specific warnings, without requiring the client to have this knowledge.
The current code would still be needed for backward-compatibility of course, so it may introduce some duplication
|
LGTM |
|
@thaJeztah why the cherry-pick here ? it's already in 17.04.0-rc1 |
|
@vieux yes, looks like it was to consider it for 17.03.1 |
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
add d_type warning to docker info, and optimize output
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The overlay(2) drivers were moved up in the list of storage drivers, and are known to have problems if the backing filesystem does not support d_type.
Commit 2e20e63 added a warning, which is logged in the daemon logs, however, many users do not check those logs, and may overlook this warning.
This patch adds the same warning to the output of
docker infoso that the warning is more easily found.In addition, the output of warnings printed by
docker infois optimized, by;Example output with this patch applied
devicemapper using loopback devices:
overlay2 on xfs without d_type support;
- Description for the changelog
Add warning to
docker infoif the overlay(2) storage driver is used , and the backing filesystem does not supportd_type.- A picture of a cute animal (not mandatory but encouraged)