Add isolation to info - enables Hyper-V containers CI bring-up #26255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowenna
force-pushed
the
jjh/xenon-test-infrastructure
branch
from
bdc2e2b
to
9fb7cee
Compare
|
LGTM, but needs a rebase |
lowenna
force-pushed
the
jjh/xenon-test-infrastructure
branch
from
9fb7cee
to
2865ea5
Compare
|
Rebased. Really weird though as there were no conflicts... github is having some issues I think! |
lowenna
force-pushed
the
jjh/xenon-test-infrastructure
branch
from
2865ea5
to
8480a98
Compare
|
Rebased again. Was real that time... |
|
ping @justincormack @vdemeester PTAL |
|
LGTM |
|
Put this in docs review, not sure if this needs anything. |
|
It needs to be added to the API documentation, and API changelog. Not sure if we want to add an example to the docker info reference (https://github.com/docker/docker/blob/master/docs/reference/commandline/info.md#display-docker-system-information), that may be a bit too much, but open to suggestions there |
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
force-pushed
the
jjh/xenon-test-infrastructure
branch
from
8480a98
to
c4e1697
Compare
|
@thaJeztah Doc updates made. Added Windows sample output in |
thaJeztah
approved these changes
Sep 26, 2016
dnephin
pushed a commit
to dnephin/docker
that referenced
this pull request
Apr 17, 2017
…cture Add isolation to info - enables Hyper-V containers CI bring-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
This enables integration tests to know the isolation mode of the daemon under test so that they can take different actions between (on Windows) Window Server containers and Hyper-V containers. This change is essential to start getting coverage of Hyper-V containers - currently there is no coverage.