Use the correct version of glide #25858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @dnephin |
|
Oops, I missed this when I converted from the original curl-the-binary to the git-checkout method. LGTM |
|
I guess |
In `man/Dockerfile` we are specifying a tagged version of glide to checkout, but never actually checking it out. This checks out the requested version before building. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
Yep, update |
|
LGTM 🐱 |
|
@dnephin Should the glide stuff not be in all the Dockerfiles? I think you can build rpms for any architecture already. |
|
Actually ppc64le has it added in #23438 so I guess we can do one by one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
man/Dockerfilewe are specifying a tagged version of glide tocheckout, but never actually checking it out.
This checks out the requested version before building.
Signed-off-by: Brian Goff cpuguy83@gmail.com