Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with -v shared folders in 1.6 #12590

Closed
dmenne opened this issue Apr 21, 2015 · 35 comments
Closed

Problem with -v shared folders in 1.6 #12590

dmenne opened this issue Apr 21, 2015 · 35 comments

Comments

@dmenne
Copy link

dmenne commented Apr 21, 2015

System: Window 7/64

With:

Boot2Docker version 1.5.0, build master : a66bce5 - Tue Feb 10 23:31:27 UTC 2015 

docker run \
  -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
  hello-world

is a valid command. This is a simplified and function-less test version, see below for the "real" one. Note that /Dieter is a valid user, please replace for testing.

With

$ docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): windows/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

I could not find out how to define the path in -v; I tried several of the variants mentioned in the docs of 1.5 on shared folders.

$ docker run \
>   -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
>   hello-world
invalid value "c:\\Users\\Dieter\\Documents\\Gastrobase;C:\\Program Files (x86)\\Git\\home\\shiny\\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

---- Real application -------------

docker run --restart=always --name gastrobase -d -p 3838:3838 \
  -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
  dmenne/gastro-docker


Dieter@DIETERPC ~
$ docker run --restart=always --name gastrobase -d -p 3838:3838 \
>   -v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase \
>   dmenne/gastro-docker
invalid value "c:\\Users\\Dieter\\Documents\\Gastrobase;C:\\Program Files (x86)\\Git\\home\\shiny\\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

@jessfraz
Copy link
Contributor

I don't understand how this could be a regression when there was never a
docker client version you could run on windows before.

On Tuesday, April 21, 2015, Dieter Menne notifications@github.com wrote:

System: Window 7/64

With:

Boot2Docker version 1.5.0, build master : a66bce5 - Tue Feb 10 23:31:27 UTC 2015

docker run
-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
hello-world

is a valid command. This is a simplified and function-less test version,
see below for the "real" one. Note that /Dieter is a valid user, please
replace for testing.

With

$ docker version
Client version: 1.6.0
Client API version: 1.18
Go version (client): go1.4.2
Git commit (client): 4749651
OS/Arch (client): windows/amd64
Server version: 1.6.0
Server API version: 1.18
Go version (server): go1.4.2
Git commit (server): 4749651
OS/Arch (server): linux/amd64

I could not find out how to define the path in -v; I tried several of the
variants mentioned in the docs of 1.5 on shared folders.

$ docker run \

-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
hello-world
invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.

---- Real application -------------

docker run --restart=always --name gastrobase -d -p 3838:3838
-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
dmenne/gastro-docker

Dieter@DIETERPC ~
$ docker run --restart=always --name gastrobase -d -p 3838:3838 \

-v /c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase
dmenne/gastro-docker
invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Ga
strobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path
See 'c:\Program Files\Boot2Docker for Windows\docker.exe run --help'.


Reply to this email directly or view it on GitHub
#12590.

@dmenne
Copy link
Author

dmenne commented Apr 21, 2015

Maybe I should change the title to "Boot2Docker". And the -v parameter has the same --help documentation as before.

@calavera
Copy link
Contributor

I don't think this is an issue parsing volumes in Docker, not really related to Boot2Docker itself. The volume path validation assumes that there is only one : in the string to separated host and container paths. In windows, that's not true.

See https://github.com/docker/docker/blob/master/opts/opts.go#L150

This test should expose the issue:

diff --git c/integration-cli/docker_cli_run_windows_test.go i/integration-cli/docker_cli_run_windows_test.go
new file mode 100644
index 0000000..53c69d6
--- /dev/null
+++ i/integration-cli/docker_cli_run_windows_test.go
@@ -0,0 +1,26 @@
+// +build windows
+
+package main
+
+import (
+       "fmt"
+       "io/ioutil"
+       "os"
+       "os/exec"
+
+       "github.com/docker/docker/vendor/src/github.com/go-check/check"
+)
+
+// Test that creating a container with a volume doesn't crash. See #12590
+func (s *DockerSuite) TestRunCreateVolumeAbsoluteWindowsPath(c *check.C) {
+       tmpDir, err := ioutil.TempDir("", "docker-test-container")
+       if err != nil {
+               c.Fatal(err)
+       }
+
+       defer os.RemoveAll(tmpDir)
+       cmd := exec.Command(dockerBinary, "run", "-v", fmt.Sprintf("%s:/tmp/docker-test-container", tmpDir), "busybox", "true")
+       if _, err := runCommand(cmd); err != nil {
+               c.Fatal(err)
+       }
+}

@ahmetb
Copy link
Contributor

ahmetb commented Apr 22, 2015

@calavera you're passing a windows path to -v in your test. That's not supported. Currently both parts of the -v should be unix paths because Docker engine is running on Linux.

@ahmetb
Copy link
Contributor

ahmetb commented Apr 22, 2015

@dmenne

If you're using git bash on windows, msysgit converts paths like /c/users to c:\users (not something you want because the path inside the boot2docker VM is /c/Users)

Try surrounding -v value with single quotes like:

... -v '/c/Users:/path' ...

On cmd.exe/powershell you shouldn't be having this problem. Does this solve the issue?

@calavera
Copy link
Contributor

that makes sense, thanks @ahmetalpbalkan.

@dmenne
Copy link
Author

dmenne commented Apr 23, 2015

I had tried the ' ' before, but the error message is the same in all cases:

docker run -v '/c/Users/Dieter/Documents/Gastrobase:/home/shiny/Gastrobase'  hello-world

invalid value "c:\Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase" for flag -v: \Users\Dieter\Documents\Gastrobase;C:\Program Files (x86)\Git\home\shiny\Gastrobase is not an absolute path

Check the error message: for reasons I do not understand, the current msysgit path is appended to the evaluated value: C:\Program Files (x86)\Git\home\shiny\Gastrobase.

I admit that I was not successful testing it on cmd/Powershell. After setting the DOCKER_XXX variables and checking that the cert-path exists, I always get the "Are you trying to connect ... TLS" message. Setting SET DOCKER_TLS_VERIFY=0 did not help. Sorry if I missed something obvious.

@dmenne dmenne closed this as completed Apr 23, 2015
@ahmetb
Copy link
Contributor

ahmetb commented Apr 23, 2015

@dmenne I think it's happening just because of the weird path interpretation of msysgit. In -v we separate paths with :, and : is also used as drive letter separator (as in c:) and that's why I think it's getting confused.

I'd just try turning that feature off if possible in msys window or try stuff like

... -v 'path1:'path2' ...

But that shouldn't be really an issue on windows consoles.

@dmenne
Copy link
Author

dmenne commented Apr 23, 2015

-v 'path1:'path2'

I assume it's a typo, both paths should be in ''? I have tried both version with the same result, i.e. 'path1:path2' and 'path1':'path2'.

"Should not be an issue on windows consoles": But most people will use the default Boot2Docker console, I assume. And : I could not get the Windows consoles to work because of the dreaded TLS. I must have missed something in the docs.

@ahmetb
Copy link
Contributor

ahmetb commented Apr 23, 2015

@dmenne you're right. I'll take a look to make it better on msys. In order to make it work in Windows consoles, run "boot2docker shellinit" and paste the output to your console and it should work exactly the same as it was in b2d window.

@dmenne
Copy link
Author

dmenne commented Apr 23, 2015

Confirmed. Everything works without errors in Powershell and cmd.
Thanks. Nevertheless, a fix for the msys-bug would be nice.

@brettp
Copy link

brettp commented Apr 27, 2015

A hacky workaround for mysys is to use double leading slashes on the path:

docker run -v //c/Users/brettp/app:/app

@dmenne
Copy link
Author

dmenne commented Apr 27, 2015

Krr... I thought I had tried that variant, but possible only with backslashes. Does not look hacky, but quite ok and works. Thank's for sharing. Could we put that into the docs of shared folders?

@ahmetb
Copy link
Contributor

ahmetb commented Apr 27, 2015

@brettp looks nice to me heh. a docs pr would be awesome

@lwlsonjlg
Copy link

Yes ... that works ... why?

lwilson@LENOVO-LAPTOP ~
$ docker run ubuntu:14.04 //bin/echo 'Hello world'
Hello world

lwilson@LENOVO-LAPTOP ~
$

@lwlsonjlg
Copy link

sorry ... that last comment was for #13741

@jakob-grabner
Copy link

For everyone who still has a problem with mounting a folder on Windows. Make sure your drive letter is lowercase.

docker run -i -t -v /c/Users/Jakob/src:/mnt some_container

@udoless
Copy link

udoless commented Dec 31, 2015

docker run -v //c/Users/brettp/app:/app
Worked!

@dmenne
Copy link
Author

dmenne commented Jan 5, 2016

Everyone reading this thread and the partially conflicting answers should be aware that it covers versions 1.6 to 1.9, and several issues have been resolved and came up new on the way. Currently, with Kitematic, things work without problems for me.
To avoid further confusion: Please add your boot2docker version when posting here.

@ericis
Copy link

ericis commented Jan 8, 2016

I had this issue and the double slash prefix to the host path fixed it for me.

System: Windows 10 Enterprise x64
Docker Toolbox: Docker v1.9.1, Docker Machine v0.5.5

*Using the "Docker Quickstart Terminal" that runs MINGW64

@kumarharsh
Copy link

I'm trying to run this command in Powershell:

docker run -u postgres --net host -v /`pwd`/file.sql://tmp/setup.sql --rm postgres:9.4 psql -h localhost -U postgres -f //tmp/setup.sql my_db;

which is giving me an error:

psql:/tmp/setup.sql:0: could not read from input file: Is a directory

I tried investigating the matter, by running bash inside the container:

docker run -it -u postgres --net host -v /`pwd`/file.sql://tmp/setup.sql --rm postgres:9.4 bash

and then I ls -l-ed the /tmp directory, and sure enough, it shows the setup.sql as a directory!

Any help?

@kumarharsh
Copy link

I figured out why the previous bug was happening: It was because my pwd was in D:\ drive, and D:\ drive is not mounted by default. To mount it, I followed the instructions given here: http://stackoverflow.com/a/32030385/630170

Now, the issue is that using git / msys2's bash makes it impossible to mount the D:\ volumes using either of these:

(with leading slash)

docker run ... -v //d/Workspace/000_init.sql:/tmp/file --rm cat /tmp/file

which gives this error: cat: C:/Users/usr/AppData/Local/Temp/file: No such file or directory

or

(without leading slash) or (with single quotes) or (with double quotes)

docker run ... -v /d/Workspace/000_init.sql:/tmp/file --rm cat /tmp/file

which gives this error:

invalid value "D:\\Workspace\\000_init.sql;C:\\Users\\usr\\AppData\\Local\\Temp\\file" for flag -v: bad mode specified: \Users\usr\AppData\Local\Temp\file
See 'C:\Program Files\Docker Toolbox\docker.exe run --help'.

@kumarharsh
Copy link

To complete the solution, I just wrote a small powershell script to do the task which my makefile was trying to do. Seems to be the only way for now.

@krishna81m
Copy link

This hack seems to work like a charm if you have downgraded to 1.9 from the AUFS issues in 1.9.1

docker create -v //c/Users/myuser:/myuser --name data hello-world
winpty docker run -it --rm --volumes-from data ubuntu

@mzvast
Copy link

mzvast commented Feb 3, 2016

double // before win path works for me,thanks a lot:)

@alexeenka
Copy link

I have the same problem on my Windows 7, thanks for thread, i find a solution. In my case following works:

docker run -it --rm -v '//c/Users/user/!prj:/home/jenkins/prj' profile_name bash

johndmulhausen added a commit to docker/docs that referenced this issue Jan 19, 2017
* d4mac, d4win stable 1.12.5 and beta 34 updates

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* fix punctuation typos (#949)

Signed-off-by: Jie Luo <luo612@zju.edu.cn>

* fix the error of handing a and an (#953)

* delete error asterisk (#947)

Signed-off-by: tim-zju <21651152@zju.edu.cn>

* fix the grammer in aws.md (#948)

* fix the grammer in aws.md

* a and an

* modify the user name (#946)

* Update create-swarm.md (#954)

Removes some spaces that were apparently b0rking the code block there.

* Add release notes for DTR 2.1.3

* spell errors: misusing a and an

Signed-off-by: tim-zju <21651152@zju.edu.cn>

* duplicated the (#957)

Signed-off-by: Jie Luo <luo612@zju.edu.cn>

* Lossless Image optimization (#959)

* re-compress jpg images losslessly using jpegoptim

* re-compress png images losslessly using zopflipng

* Add release notes for 1.12.5-cs

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Fix wrong entry for DTR in robots.txt

* Update step_four.md

* fix typo

* Replace dtr-load-balancer by dtr-external-url

Fixes #961

* explained how to pin whale to taskbar

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* updated d4mac release notes re: hotfix

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Clean up some big, old files

* Fix typo on engine/getstarted/step_four.md

* Update gcs.md

Forgotten </td> caused table explosion

* Use armhf/hello-world for Raspbian tutorial

Signed-off-by: Stefan Scherer <scherer_stefan@icloud.com>

* added test for absolute links to docs.docker.com

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* made absolute links to docs.docker.com relative

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed absolute link in engin/installation/binaries

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* changes in Jenkinsfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* look for href and src attributes in a and img tags

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* look for absolute links to docs.docker.com

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* forgotten absolute links in Dockerfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* updated docs.docker.com absolute links test

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Revert "forgotten absolute links in Dockerfile"

This reverts commit ca54f76.

We want to fix the root cause, not the symptoms. So let’s make sure original content is fine instead of fixing it at build.

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* exclude archives when testing urls for now

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* CI: don’t build jekyll redirects for now

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Updated format for comments in Jenkinsfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* tests: Go deps are now vendored as submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Jenkinsfile: init submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* made absolute links to docs.docker.com relative

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* missing “target=_blank”

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* links to md files

as requested by @mstanleyjones

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* typo fixed

* Update host_integration.md

Typically, when you run an image from the command line, you would use "-d" for "detached mode", and when that appears to work, someone might paste the working command line into "ExecStart", which would then mysteriously fail because ExecStart expects a foreground process.

* Excess '>' symbol deleted

* Sometime the disk can become full and you can't rebalance.  Adding this step to the configuration instructions to help prevent users from getting in to a state which their device becomes full.

Moved to the performance section.

Signed-off-by: charlescva <charlieott@gmail.com>

* added user question in FAQ re: shared drives and Docker Machine nodes

copyedit

incorporated Misty's review comments

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Standardize formatting and content, add logging examples

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update index.md

fix the typo

* Update deploy-to-cloud-btn.md

Add note about having to be logged into Docker Cloud...

* fixed note formatting

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* update d4mac, d4win intros, add better feedback topics

copyedits

more copyedits

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Replace bash shell to powershell in docker for windows

Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>

* Update overview.md

Update overview.md to reference possible issues regarding windows to unix path convert issues

* Update ubuntulinux.md

* Improved description for Hello-World

Adds more detail for people to be able to understand how to build the Hello World using FROM scratch.

* Update services.md

Correct typographical error.

* Correct wrong default value

* fixes #1014 by adding flag

Signed-off-by: LRubin <lrubin@docker.com>

* small clarifications

Signed-off-by: LRubin <lrubin@docker.com>

* update swarm worker node concept description

incorporated review comments from Misty

re-worded topic titles and added to description of node

fixed links for services and tasks

incorporated more comments

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update to usingdocker.md

Link destination changed toa more appropriate (imo) destination.

Link originally linked to docker env varibles whereas link description describes other docker commands.

* Updating dockervolumes.md for Windows mounting

The code snippet for mounting Windows directories won't work: it will produce an "Invalid bind mount spec" error as Docker cannot properly read the path. The core error was addressed in [#12590](moby/moby#12590 (comment)), this is just an update to the tutorial.

* using github url for yaml.v2 submodule (#1034)

in an attempt to fix Github pages build…

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* clarify docker-cloud install

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Add flag to ucp 2.0 restore instructions

* Add flag to ucp 2.0 restore instructions

* update Docker machine install instructions per user feedback

added uninstall steps

fixed line lengths

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Typo in ubuntulinux.md (#1041)

* version changed to 1.12.3 (#1036)

* update the version in the code snnipt (#1037)

* docker upgrade command fix (#1044)

`apt-get upgrade` doesn't take an argument. To upgrade docker specifically would require `apt-get install docker-engine`.

* accross -> across

* beta 35 release notes d4mac, d4win

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Remove duplicate 'for details' 

Remove duplicate 'for details' in Docker Daemon Attack Surface line.

* Update automated-testing.md

Updated text to reflect that the `docker-compose.test.yml` file needs to be in the same directory as the Dockerfile used to build the image.

* Add prereqs to AUFS configuration steps

Fixes #1061

* Add the info about the linux-image-extra packages

* Fix typo (are -> area) (#1058)

* Fix title (#1056)

The title is not rendered correctly because of the missing newline

* Fix small typo in step_four.md. (#1053)

* Fix DDC broken links reported on #1068

* Update networkingcontainers.md

* Change title (#1073)

* urls (#1074)

Signed-off-by: yupengzte <yu.peng36@zte.com.cn>

* fixed links in /apidocs/docker-cloud/includes

urls in html files that are included must be absolute, otherwise it only works when the files are included in some specific location.

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* cf6fc37 fix had to be made in /apidocs/cloud-api-source

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* url fixes for #1068

Signed-off-by: LRubin <lrubin@docker.com>

* Fixes #1086

* more link fixes

Signed-off-by: LRubin <lrubin@docker.com>

* exclude /apidocs/cloud-api-source when building

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* more more link link fixes fixes

Signed-off-by: LRubin <lrubin@docker.com>

* docker is no longer optional in this tutorial

Signed-off-by: LRubin <lrubin@docker.com>

* format fix and light rewording

Signed-off-by: LRubin <lrubin@docker.com>

* Always use sudo on Debian installation

* docker-for-mac: add a FAQ about reducing the qcow2 size

In Docker for Mac 1.12 the only way to free space on the host is to
delete the qcow2 which means all containers and images have to be
rebuilt.

In Docker for Mac 1.13 there is preliminary support for shrinking the
qcow2 file non-destructively using "TRIM" (as also used on SSDs).
Unfortunately this isn't (yet) fully automatic -- it runs in the
background and requires the app to be occasionally restarted.

Related to [docker/for-mac#371]

Signed-off-by: David Scott <dave.scott@docker.com>

* Update instructions for systemd drop-ins

When creating a `/etc/systemd/system/docker.service`
unit file, that file _replaces_ the default
(`/lib/systemd/system/docker.service`) unit file.

While this may be intended by some, this section
describes how to use "partial" unit files ("drop-ins")
to override only certain properties of the default
unit file.

This patch removes the mention of
`/etc/systemd/system/docker.service` to prevent
users from inadvertently replacing the default
unit file.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Add cs-engine 1.12.6-cs6 release notes

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Add new redirect for DTR install

* Add 1.11.2-cs6 release notes

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Updates broken links for #1068

* added links to Toolbox installer downloads via Releases page

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update links to DTR

* tag images and containers with JOB_BASE_NAME + BUILD_NUMBER

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Add release notes for 1.10.3-cs4

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* added direct installer links, re-worked Toolbox intro pages

updated Toolbox install intros

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Remove reference to legacy container links (#1057)

* Removes duplicate canonical urls

* Fix root_ca, json structure (#1079)

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>

* Correction of the Install-Module command (#1102)

The command line was Import-Module which seems to be wrong. It seemed to work for me with Install-Module. So I make the correction. Please note, I'm only a newbie, so check this twice please ;-)

* linked to related GitHub issue, slight re-ordering of topics

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update PULL_REQUEST_TEMPLATE.md (#1106)

Change 'left' to 'right' (because that's where the referenced information is located.

* Add alternative keyservers due to #13555 (#1048)

* Update step_six.md (#1105)

* Update get-started-macvlan.md

fix typo

* added beta 36 relnotes, and minor wording updates to Docker.qcow2 question in Mac FAQs

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* clarify Toolbox install per Nathan's comments

centered download buttons for overview Toolbox install

improved Get Docker intro in Getting Started tutorial

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Fixed more broken links

* fix typo in get-started-macvlan.md (#1121)

* added Linux Kernel upgrade to relnotes

added new bug fix item

toolbox fixes

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update get-started-overlay.md (#1082)

* Update get-started-overlay.md

* Update get-started-overlay.md

perhaps renderer can't do multiline markdown links

* Update get-started-overlay.md

* Remove 'edit this page' button when there's no source file

* Adds dynamically-generated redirect_from.csv to root for nginx consumption

* Correct typo

"For image" changed to "For instance"

* Update hyper-v.md

* correct some spelling mistake

* fix typo in swarm tutorial

* Correct Python application port for local browsing

* Updates allpagelinks.md to use full paths (#1143)

* Fix documentation regarding protocol 50 (ESP) (#1144)

The documentation should clarify that its protocol 50 and not port 50 that should be allowed between nodes.

* Update mongodb.md (#1122)

In older version docker build was failing.

* CI - added tests for relative links [DO NOT MERGE] (#1052)

* CI - added tests for relative links

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixes to check relative links properly

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* /engine/extend/plugins/ -> /engine/extend/legacy_plugins/

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* do not build /tests folder with Jekyll…

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* list all problematic urls in each file

don’t stop at first error encountered

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* removed “stack tasks” from menu (toc.yaml)

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken links

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken link in docker-for-mac/osxfs.md

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken links in /index.html

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Add release notes for DTR 2.1.4

* Fix offline DDC install

* Add offline tarfile for DTR 2.1.4

* Update instructions for IPv6-enabled networks

Signed-off-by: Joffrey F <joffrey@docker.com>

* Fix searches not running on Enter, CS Release notes

* Restart the docker daemon after group changes

Otherwise the verification step won't work.

* Remove quotation marks

Remove quotation marks around environment variable export for DOCKERCLOUD_NAMESPACE

* optimize  selectadriver.md

* Permission Levels Full Control Warning (UCP 2.0)

* Full Control Users Warning (UCP 1.1)

* improve readability of note

Signed-off-by: LRubin <lrubin@docker.com>

* Update release notes for UCP 2.0.2

* Release notes for UCP 1.1.6

* replaces edit from #979

Signed-off-by: LRubin <lrubin@docker.com>

* Update 2_set_up.md

* adds more info about valid docker ID

Signed-off-by: LRubin <lrubin@docker.com>

* fix typo

* Update 'usingdocker' tutorial to name the container

Do some clean-up while I'm in there

* swarm beta docs for limited publish

Signed-off-by: LRubin <lrubin@docker.com>

* Clarify the command only for docker-machine (#1149)

* Clarify the command only for docker-machine

* minor copyedits (#1148)

* minor copyedits

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Revert "Restart the docker daemon after group changes"

* take a stab at fixing a broken link

Signed-off-by: LRubin <lrubin@docker.com>

* Release Engine 1.13 documentation (#1187)

* Sync vnext-engine branch to docker/docker SHA 2f12d28

This branch will contain forward-looking Engine-specific docs
and be the equivalent of docker/docker master for docs

* swarm: Document rollback, failure threshold, and monitor flags

These are new flags to service create/update being added in a Docker
engine PR.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

* Remove Fedora 22 as it's EOL

https://fedoramagazine.org/fedora-22-end-of-life-2016-july/

With the recent release of Fedora 24, Fedora 22 will officially enter End Of
Life (EOL) status on July 19th, 2016. After July 19th, all packages in the
Fedora 22 repositories will no longer receive security, bugfix, or enhancement
updates, and no new packages will be added to the Fedora 22 collection.

Upgrading to Fedora 23 or Fedora 24 before July 19th 2016 is highly recommended
for all users still running Fedora 22.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* update apparmor documentation to reflect changes in 1.13.0

Updates the apparmor docs to reflect recent changes, specifically that
we are no longer saving to /etc/apparmor.d/. Also removes the seccomp
profile and instead links to the generating template.

Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>

* Added details about tag support for AWS log driver

Signed-off-by: French Ben <frenchben@docker.com>

* Changed wording for tag description

* Updated docs to show full container ID

* Updated wording on log stream default

Signed-off-by: French Ben <frenchben@docker.com>

* Added raw tags

Signed-off-by: French Ben <frenchben@docker.com>

* Update note about custom certs with system certs

Fixed incorrect statement about example layout

Related to moby/moby#27918

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)

* Remove Ubuntu 15.10 Wily Werewolf

As of July 28, 2016, Ubuntu 15.10 is officially EOL
(https://lists.ubuntu.com/archives/ubuntu-announce/2016-July/000210.html),
and will receive no further updates.

Support for 15.10 was removed in Docker 1.13 through
moby/moby#27042

(moby/moby@e9a8105)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Add Ubuntu 16.10 Yakkety Yak

Support for Ubuntu 16.10 was added in
moby/moby#27993
(moby/moby@27beb64)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* add unix-sockets support in Fluentd logging driver

Signed-off-by: Akira Koyasu <mail@akirakoyasu.net>

* Add engine changes that were lost in syncing

When syncing docs from the docker/docker repository (e4bce35)
some commits were not included. This includes those changes, by copying the documentation from

moby/moby@8658748,
which is the last commit before the docs were removed from the docker/docker
repository in moby/moby@29f08cf

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Create logentries.md (#244)

* Create logentries.md

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>

* Add NATS client as option for publishing container logs (#369)

* Add NATS client as option for publishing container logs

Signed-off-by: Waldemar Quevedo <waldemar.quevedo@gmail.com>

* Document ability to update a service's image

Fixes #528

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* First version of stack deployment tutorial

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>

* Initial dump of CLI in yaml (#737)

Signed-off-by: French Ben <frenchben@docker.com>

* Document new CPU scheduling flags

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update dockerfile vnext (#874)

* Merge pull request #731 from mstanleyjones/distribution_docs_from_upstream

Pull distribution reference docs from upstream repo

* Bump Engine ref docs branch to 1.13.x

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Rename Remote API to Engine API

See moby/moby#28319

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Move accounts API docs to Docker ID section

Makes more sense here instead of the Engine reference. It is
only consumed by the Engine.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Add automatically generated Engine API docs

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Upgrade to ReDoc 1.6.2 (#891)

To make use of x-displayName added in
moby/moby#29401

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Add full documentation for APIs and SDKs

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Updated Yaml files (#922)

Signed-off-by: French Ben <frenchben@docker.com>

* Added latest docs from Editions AWS & Azure (#887)

* Added Docker for AWS and Azure and moved navigation

Signed-off-by: French Ben <frenchben@docker.com>

* Fixed image links

Signed-off-by: French Ben <frenchben@docker.com>

* Restructure navigation for Editions

* Fixing double curly braces

* YAML-sourced CLI refdocs

* Add 'docker' label to commands

* Fix for blank node

* Document Docker secrets

Fixes #529

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update syntax of the -f flag in the examples

* Update the syntax of 'docker secret create' in the examples

* Document the ability to publish a port locally on a swarm node

* Add info about image resolution with content trust

* Add examples to CLI generation templates

* remove confusing sentence from "publishing" section

the routing mesh should work irregardless of all
replicas being up or not, so removing this sentence.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Rewrite and reorganize Linux install instructions

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Fix typo in Oracle install instructions

* Updated docs to remove beta and stable link (#1160)

* Updated docs to remove beta and stable link

* Addressing feedback from new installation instructions (#1172)

* Address feedback for new installation instructions

* Updating the repo files for Oracle since  does not expand to only the number

* Added latest docs from Editions AWS & Azure (#887)

* Added Docker for AWS and Azure and moved navigation

Signed-off-by: French Ben <frenchben@docker.com>

* Fixed image links

Signed-off-by: French Ben <frenchben@docker.com>

* Restructure navigation for Editions

* Fix a couple of Liquid errors

* Merge pull request #1188 from docker/linkfix-john

Link fixes and link to app tutorial
johndmulhausen pushed a commit to docker/docs that referenced this issue Jan 19, 2017
* fix punctuation typos (#949)

Signed-off-by: Jie Luo <luo612@zju.edu.cn>

* fix the error of handing a and an (#953)

* delete error asterisk (#947)

Signed-off-by: tim-zju <21651152@zju.edu.cn>

* fix the grammer in aws.md (#948)

* fix the grammer in aws.md

* a and an

* modify the user name (#946)

* Update create-swarm.md (#954)

Removes some spaces that were apparently b0rking the code block there.

* Add release notes for DTR 2.1.3

* spell errors: misusing a and an

Signed-off-by: tim-zju <21651152@zju.edu.cn>

* duplicated the (#957)

Signed-off-by: Jie Luo <luo612@zju.edu.cn>

* Lossless Image optimization (#959)

* re-compress jpg images losslessly using jpegoptim

* re-compress png images losslessly using zopflipng

* Add release notes for 1.12.5-cs

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Fix wrong entry for DTR in robots.txt

* Update step_four.md

* fix typo

* Replace dtr-load-balancer by dtr-external-url

Fixes #961

* explained how to pin whale to taskbar

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* updated d4mac release notes re: hotfix

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Clean up some big, old files

* Fix typo on engine/getstarted/step_four.md

* Update gcs.md

Forgotten </td> caused table explosion

* Use armhf/hello-world for Raspbian tutorial

Signed-off-by: Stefan Scherer <scherer_stefan@icloud.com>

* added test for absolute links to docs.docker.com

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* made absolute links to docs.docker.com relative

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed absolute link in engin/installation/binaries

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* changes in Jenkinsfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* look for href and src attributes in a and img tags

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* look for absolute links to docs.docker.com

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* forgotten absolute links in Dockerfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* updated docs.docker.com absolute links test

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Revert "forgotten absolute links in Dockerfile"

This reverts commit ca54f76.

We want to fix the root cause, not the symptoms. So let’s make sure original content is fine instead of fixing it at build.

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* exclude archives when testing urls for now

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* CI: don’t build jekyll redirects for now

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Updated format for comments in Jenkinsfile

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* tests: Go deps are now vendored as submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Jenkinsfile: init submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed submodules

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* made absolute links to docs.docker.com relative

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* missing “target=_blank”

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* links to md files

as requested by @mstanleyjones

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* typo fixed

* Update host_integration.md

Typically, when you run an image from the command line, you would use "-d" for "detached mode", and when that appears to work, someone might paste the working command line into "ExecStart", which would then mysteriously fail because ExecStart expects a foreground process.

* Excess '>' symbol deleted

* Sometime the disk can become full and you can't rebalance.  Adding this step to the configuration instructions to help prevent users from getting in to a state which their device becomes full.

Moved to the performance section.

Signed-off-by: charlescva <charlieott@gmail.com>

* added user question in FAQ re: shared drives and Docker Machine nodes

copyedit

incorporated Misty's review comments

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Standardize formatting and content, add logging examples

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update index.md

fix the typo

* Update deploy-to-cloud-btn.md

Add note about having to be logged into Docker Cloud...

* fixed note formatting

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* update d4mac, d4win intros, add better feedback topics

copyedits

more copyedits

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Replace bash shell to powershell in docker for windows

Signed-off-by: yuexiao-wang <wang.yuexiao@zte.com.cn>

* Update overview.md

Update overview.md to reference possible issues regarding windows to unix path convert issues

* Update ubuntulinux.md

* Improved description for Hello-World

Adds more detail for people to be able to understand how to build the Hello World using FROM scratch.

* Update services.md

Correct typographical error.

* Correct wrong default value

* fixes #1014 by adding flag

Signed-off-by: LRubin <lrubin@docker.com>

* small clarifications

Signed-off-by: LRubin <lrubin@docker.com>

* update swarm worker node concept description

incorporated review comments from Misty

re-worded topic titles and added to description of node

fixed links for services and tasks

incorporated more comments

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update to usingdocker.md

Link destination changed toa more appropriate (imo) destination.

Link originally linked to docker env varibles whereas link description describes other docker commands.

* Updating dockervolumes.md for Windows mounting

The code snippet for mounting Windows directories won't work: it will produce an "Invalid bind mount spec" error as Docker cannot properly read the path. The core error was addressed in [#12590](moby/moby#12590 (comment)), this is just an update to the tutorial.

* using github url for yaml.v2 submodule (#1034)

in an attempt to fix Github pages build…

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* clarify docker-cloud install

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Add flag to ucp 2.0 restore instructions

* Add flag to ucp 2.0 restore instructions

* update Docker machine install instructions per user feedback

added uninstall steps

fixed line lengths

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Typo in ubuntulinux.md (#1041)

* version changed to 1.12.3 (#1036)

* update the version in the code snnipt (#1037)

* docker upgrade command fix (#1044)

`apt-get upgrade` doesn't take an argument. To upgrade docker specifically would require `apt-get install docker-engine`.

* accross -> across

* beta 35 release notes d4mac, d4win

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Remove duplicate 'for details' 

Remove duplicate 'for details' in Docker Daemon Attack Surface line.

* Update automated-testing.md

Updated text to reflect that the `docker-compose.test.yml` file needs to be in the same directory as the Dockerfile used to build the image.

* Add prereqs to AUFS configuration steps

Fixes #1061

* Add the info about the linux-image-extra packages

* Fix typo (are -> area) (#1058)

* Fix title (#1056)

The title is not rendered correctly because of the missing newline

* Fix small typo in step_four.md. (#1053)

* Fix DDC broken links reported on #1068

* Update networkingcontainers.md

* Change title (#1073)

* urls (#1074)

Signed-off-by: yupengzte <yu.peng36@zte.com.cn>

* fixed links in /apidocs/docker-cloud/includes

urls in html files that are included must be absolute, otherwise it only works when the files are included in some specific location.

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* cf6fc37 fix had to be made in /apidocs/cloud-api-source

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* url fixes for #1068

Signed-off-by: LRubin <lrubin@docker.com>

* Fixes #1086

* more link fixes

Signed-off-by: LRubin <lrubin@docker.com>

* exclude /apidocs/cloud-api-source when building

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* more more link link fixes fixes

Signed-off-by: LRubin <lrubin@docker.com>

* docker is no longer optional in this tutorial

Signed-off-by: LRubin <lrubin@docker.com>

* format fix and light rewording

Signed-off-by: LRubin <lrubin@docker.com>

* Always use sudo on Debian installation

* docker-for-mac: add a FAQ about reducing the qcow2 size

In Docker for Mac 1.12 the only way to free space on the host is to
delete the qcow2 which means all containers and images have to be
rebuilt.

In Docker for Mac 1.13 there is preliminary support for shrinking the
qcow2 file non-destructively using "TRIM" (as also used on SSDs).
Unfortunately this isn't (yet) fully automatic -- it runs in the
background and requires the app to be occasionally restarted.

Related to [docker/for-mac#371]

Signed-off-by: David Scott <dave.scott@docker.com>

* Update instructions for systemd drop-ins

When creating a `/etc/systemd/system/docker.service`
unit file, that file _replaces_ the default
(`/lib/systemd/system/docker.service`) unit file.

While this may be intended by some, this section
describes how to use "partial" unit files ("drop-ins")
to override only certain properties of the default
unit file.

This patch removes the mention of
`/etc/systemd/system/docker.service` to prevent
users from inadvertently replacing the default
unit file.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Add cs-engine 1.12.6-cs6 release notes

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Add new redirect for DTR install

* Add 1.11.2-cs6 release notes

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* Updates broken links for #1068

* added links to Toolbox installer downloads via Releases page

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update links to DTR

* tag images and containers with JOB_BASE_NAME + BUILD_NUMBER

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Add release notes for 1.10.3-cs4

Signed-off-by: Brian Goff <cpuguy83@gmail.com>

* added direct installer links, re-worked Toolbox intro pages

updated Toolbox install intros

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Remove reference to legacy container links (#1057)

* Removes duplicate canonical urls

* Fix root_ca, json structure (#1079)

Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>

* Correction of the Install-Module command (#1102)

The command line was Import-Module which seems to be wrong. It seemed to work for me with Install-Module. So I make the correction. Please note, I'm only a newbie, so check this twice please ;-)

* linked to related GitHub issue, slight re-ordering of topics

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update PULL_REQUEST_TEMPLATE.md (#1106)

Change 'left' to 'right' (because that's where the referenced information is located.

* Add alternative keyservers due to #13555 (#1048)

* Update step_six.md (#1105)

* Update get-started-macvlan.md

fix typo

* added beta 36 relnotes, and minor wording updates to Docker.qcow2 question in Mac FAQs

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* clarify Toolbox install per Nathan's comments

centered download buttons for overview Toolbox install

improved Get Docker intro in Getting Started tutorial

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Fixed more broken links

* fix typo in get-started-macvlan.md (#1121)

* added Linux Kernel upgrade to relnotes

added new bug fix item

toolbox fixes

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Update get-started-overlay.md (#1082)

* Update get-started-overlay.md

* Update get-started-overlay.md

perhaps renderer can't do multiline markdown links

* Update get-started-overlay.md

* Remove 'edit this page' button when there's no source file

* Adds dynamically-generated redirect_from.csv to root for nginx consumption

* Correct typo

"For image" changed to "For instance"

* Update hyper-v.md

* correct some spelling mistake

* fix typo in swarm tutorial

* Correct Python application port for local browsing

* Updates allpagelinks.md to use full paths (#1143)

* Fix documentation regarding protocol 50 (ESP) (#1144)

The documentation should clarify that its protocol 50 and not port 50 that should be allowed between nodes.

* Update mongodb.md (#1122)

In older version docker build was failing.

* CI - added tests for relative links [DO NOT MERGE] (#1052)

* CI - added tests for relative links

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixes to check relative links properly

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* /engine/extend/plugins/ -> /engine/extend/legacy_plugins/

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* do not build /tests folder with Jekyll…

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* list all problematic urls in each file

don’t stop at first error encountered

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* removed “stack tasks” from menu (toc.yaml)

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken links

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken link in docker-for-mac/osxfs.md

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* fixed broken links in /index.html

Signed-off-by: Adrien Duermael <adrien@duermael.com>

* Add release notes for DTR 2.1.4

* Fix offline DDC install

* Add offline tarfile for DTR 2.1.4

* Update instructions for IPv6-enabled networks

Signed-off-by: Joffrey F <joffrey@docker.com>

* Fix searches not running on Enter, CS Release notes

* Restart the docker daemon after group changes

Otherwise the verification step won't work.

* Remove quotation marks

Remove quotation marks around environment variable export for DOCKERCLOUD_NAMESPACE

* optimize  selectadriver.md

* Permission Levels Full Control Warning (UCP 2.0)

* Full Control Users Warning (UCP 1.1)

* improve readability of note

Signed-off-by: LRubin <lrubin@docker.com>

* Update release notes for UCP 2.0.2

* Release notes for UCP 1.1.6

* replaces edit from #979

Signed-off-by: LRubin <lrubin@docker.com>

* Update 2_set_up.md

* adds more info about valid docker ID

Signed-off-by: LRubin <lrubin@docker.com>

* fix typo

* Update 'usingdocker' tutorial to name the container

Do some clean-up while I'm in there

* swarm beta docs for limited publish

Signed-off-by: LRubin <lrubin@docker.com>

* Clarify the command only for docker-machine (#1149)

* Clarify the command only for docker-machine

* minor copyedits (#1148)

* minor copyedits

Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>

* Revert "Restart the docker daemon after group changes"

* take a stab at fixing a broken link

Signed-off-by: LRubin <lrubin@docker.com>

* Release Engine 1.13 documentation (#1187)

* Sync vnext-engine branch to docker/docker SHA 2f12d28

This branch will contain forward-looking Engine-specific docs
and be the equivalent of docker/docker master for docs

* swarm: Document rollback, failure threshold, and monitor flags

These are new flags to service create/update being added in a Docker
engine PR.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>

* Remove Fedora 22 as it's EOL

https://fedoramagazine.org/fedora-22-end-of-life-2016-july/

With the recent release of Fedora 24, Fedora 22 will officially enter End Of
Life (EOL) status on July 19th, 2016. After July 19th, all packages in the
Fedora 22 repositories will no longer receive security, bugfix, or enhancement
updates, and no new packages will be added to the Fedora 22 collection.

Upgrading to Fedora 23 or Fedora 24 before July 19th 2016 is highly recommended
for all users still running Fedora 22.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* update apparmor documentation to reflect changes in 1.13.0

Updates the apparmor docs to reflect recent changes, specifically that
we are no longer saving to /etc/apparmor.d/. Also removes the seccomp
profile and instead links to the generating template.

Signed-off-by: Christopher Jones <tophj@linux.vnet.ibm.com>

* Added details about tag support for AWS log driver

Signed-off-by: French Ben <frenchben@docker.com>

* Changed wording for tag description

* Updated docs to show full container ID

* Updated wording on log stream default

Signed-off-by: French Ben <frenchben@docker.com>

* Added raw tags

Signed-off-by: French Ben <frenchben@docker.com>

* Update note about custom certs with system certs

Fixed incorrect statement about example layout

Related to moby/moby#27918

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)

* Remove Ubuntu 15.10 Wily Werewolf

As of July 28, 2016, Ubuntu 15.10 is officially EOL
(https://lists.ubuntu.com/archives/ubuntu-announce/2016-July/000210.html),
and will receive no further updates.

Support for 15.10 was removed in Docker 1.13 through
moby/moby#27042

(moby/moby@e9a8105)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Add Ubuntu 16.10 Yakkety Yak

Support for Ubuntu 16.10 was added in
moby/moby#27993
(moby/moby@27beb64)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* add unix-sockets support in Fluentd logging driver

Signed-off-by: Akira Koyasu <mail@akirakoyasu.net>

* Add engine changes that were lost in syncing

When syncing docs from the docker/docker repository (e4bce35)
some commits were not included. This includes those changes, by copying the documentation from

moby/moby@8658748,
which is the last commit before the docs were removed from the docker/docker
repository in moby/moby@29f08cf

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Create logentries.md (#244)

* Create logentries.md

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>

* Add NATS client as option for publishing container logs (#369)

* Add NATS client as option for publishing container logs

Signed-off-by: Waldemar Quevedo <waldemar.quevedo@gmail.com>

* Document ability to update a service's image

Fixes #528

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* First version of stack deployment tutorial

Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>

* Initial dump of CLI in yaml (#737)

Signed-off-by: French Ben <frenchben@docker.com>

* Document new CPU scheduling flags

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update dockerfile vnext (#874)

* Merge pull request #731 from mstanleyjones/distribution_docs_from_upstream

Pull distribution reference docs from upstream repo

* Bump Engine ref docs branch to 1.13.x

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Rename Remote API to Engine API

See moby/moby#28319

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Move accounts API docs to Docker ID section

Makes more sense here instead of the Engine reference. It is
only consumed by the Engine.

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Add automatically generated Engine API docs

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Upgrade to ReDoc 1.6.2 (#891)

To make use of x-displayName added in
moby/moby#29401

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Add full documentation for APIs and SDKs

Signed-off-by: Ben Firshman <ben@firshman.co.uk>

* Updated Yaml files (#922)

Signed-off-by: French Ben <frenchben@docker.com>

* Added latest docs from Editions AWS & Azure (#887)

* Added Docker for AWS and Azure and moved navigation

Signed-off-by: French Ben <frenchben@docker.com>

* Fixed image links

Signed-off-by: French Ben <frenchben@docker.com>

* Restructure navigation for Editions

* Fixing double curly braces

* YAML-sourced CLI refdocs

* Add 'docker' label to commands

* Fix for blank node

* Document Docker secrets

Fixes #529

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Update syntax of the -f flag in the examples

* Update the syntax of 'docker secret create' in the examples

* Document the ability to publish a port locally on a swarm node

* Add info about image resolution with content trust

* Add examples to CLI generation templates

* remove confusing sentence from "publishing" section

the routing mesh should work irregardless of all
replicas being up or not, so removing this sentence.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

* Rewrite and reorganize Linux install instructions

Signed-off-by: Misty Stanley-Jones <misty@docker.com>

* Fix typo in Oracle install instructions

* Updated docs to remove beta and stable link (#1160)

* Updated docs to remove beta and stable link

* Addressing feedback from new installation instructions (#1172)

* Address feedback for new installation instructions

* Updating the repo files for Oracle since  does not expand to only the number

* Added latest docs from Editions AWS & Azure (#887)

* Added Docker for AWS and Azure and moved navigation

Signed-off-by: French Ben <frenchben@docker.com>

* Fixed image links

Signed-off-by: French Ben <frenchben@docker.com>

* Restructure navigation for Editions

* Fix a couple of Liquid errors

* Merge pull request #1188 from docker/linkfix-john

Link fixes and link to app tutorial

* Nav fixes
@datumgeek
Copy link

just wanted to chime in and say how awesome this fix is !!!! 🥇

@kumarharsh
Copy link

kumarharsh commented Apr 14, 2017

Update: (For people running into this while using git-for-windows' flavour of msys) - I threw out the powershell script I was using earlier, and fixed the problem in the Makefile itself. I just exported MSYS_NO_PATHCONV=1 for any tasks which used linux-style paths or using pwd.

example:

.PHONY: init
init: export MSYS_NO_PATHCONV=1 # stop path conversion for msys in windows
init: ## Initialize a database
				docker run -u postgres --net host -v `pwd`/schemas/sql/postgres.sql:/tmp/setup.sql --rm postgres:9.5 psql -h localhost -U postgres -f /tmp/setup.sql code_db

Ref: git-for-windows/msys2-runtime#11

@gauravshindolkar
Copy link

Can someone help me with below command? I am quite new to docker and performing the Swarm Project of the voting app that docker documentation has. Now I am on a windows machine and after reading this thread tried to modify my commands to below, however it fails.

Command 1:
docker run -P -d -ti -v nginx:/etc/conf -v /var/lib/boot2docker:/var/lib/boot2docker:ro -v /var/run/docker.sock:/var/run/docker.sock -v //d/Docker/docker-voting-app/config/config.toml:/etc/config.toml --name interlock ehazlett/interlock:1.0.1 -D run -c /etc/config.toml

Command 2:
docker run -P -d -ti -v nginx:/etc/conf -v /var/lib/boot2docker:/var/lib/boot2docker:ro -v /var/run/docker.sock:/var/run/docker.sock -v %cd%/config.toml:/etc/config.toml --name interlock ehazlett/interlock:1.0.1 -D run -c /etc/config.toml

error

time="2017-06-11T12:43:38+05:30" level=info msg="Unable to use system certificate pool: crypto/x509: system root pool is not available on Windows"
docker: Error response from daemon: invalid bind mount spec "D:\\Docker\\docker-voting-app\\config/config.toml:/etc/config.toml": invalid mode: /etc/config.toml.
See 'docker run --help'.

Tried this in powershell and on default CMD but no luck. Still getting below error in docker logs.

PS C:\Users\Gaurav> docker logs interlock
time="2017-06-11T12:34:42+05:30" level=info msg="Unable to use system certificate pool: crypto/x509: system root pool is not available on Windows"
INFO[0000] interlock 1.0.1 (000291d)
DEBU[0000] loading config from: /etc/config.toml
FATA[0000] read /etc/config.toml: is a directory

Docker Version:

> docker version
time="2017-06-11T12:41:26+05:30" level=info msg="Unable to use system certificate pool: crypto/x509: system root pool is not available on Windows"
Client:
 Version:      17.03.1-ce
 API version:  1.27
 Go version:   go1.7.5
 Git commit:   c6d412e
 Built:        Tue Mar 28 00:40:02 2017
 OS/Arch:      windows/amd64

Server:
 Version:      17.05.0-ce
 API version:  1.29 (minimum version 1.12)
 Go version:   go1.7.5
 Git commit:   89658be
 Built:        Thu May  4 21:43:09 2017
 OS/Arch:      linux/amd64
 Experimental: false

@thaJeztah
Copy link
Member

@gauravshindolkar Please keep in mind that the GitHub issue tracker is not intended as a general support forum, but for reporting bugs and feature requests. For other type of questions, consider using one of;

@kumarharsh
Copy link

@gauravshindolkar read my solution just above your comment.

@chen-xin
Copy link

@kumarharsh thank you. I fixed this by creating an bash script:

#!/bin/bash
export MSYS_NO_PATHCONV=1
docker run --rm \
-v mynamedvol:/data \
-v $PWD/data:/backup \
alpine \
sh "tar zcvf /backup/mybackup.tar.gz /data"

@dhan2vijay
Copy link

invalid bind mount spec "c:\users\admin.wsd027\documents\visual studio 2015\Projects\aspnetcorec1\src\aspnetcorec1:/app:rw": invalid volume specification i am just getting this issue can some one please help me out

@hugokoka
Copy link

hugokoka commented Oct 2, 2017

I solved it!

Add a volume:

docker run -d -v my-named-volume:C:\MyNamedVolume testimage:latest

Mount a host directory:

docker run -d -v C:\Temp\123:C:\My\Shared\Dir testimage:latest

@matt-github-acct
Copy link

If anyone is interested, I dug into this problem and came up with a few solutions here.

Some solutions:

  1. Use MSYS_NO_PATHCONV to disable POSIX -> Windows path conversions.
  2. Pass the command off to the Windows shell.
  3. Something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests