Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd integrations tests #657

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Add etcd integrations tests #657

merged 1 commit into from
Oct 15, 2015

Conversation

mrjana
Copy link
Contributor

@mrjana mrjana commented Oct 15, 2015

- Added etcd integration test for overlay
- Added etcd integration test for multinode
  with mock test driver suitable for circleci
- Added multinode tests for zookeeper
- Made the script smart enough to only start
  data stores necessary for the requested suites

Signed-off-by: Jana Radhakrishnan mrjana@docker.com

    - Added etcd integration test for overlay
    - Added etcd integration test for multinode
      with mock test driver suitable for circleci
    - Added multinode tests for zookeeper
    - Made the script smart enough to only start
      data stores necessary for the requested suites

Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
@chenchun
Copy link
Contributor

Looks good than my PR. Closed mine.

@abronan
Copy link

abronan commented Oct 15, 2015

Maybe a small nit on the port choice (why 42000 and not 4001?).

But LGTM. Great to have tests for the 3 stores now.

@tomdee
Copy link
Contributor

tomdee commented Oct 15, 2015

Yes big 👍 to having tests for all three stores. Thanks for getting these tests in.

@mrjana
Copy link
Contributor Author

mrjana commented Oct 15, 2015

@abronan I chose 42000 since 4001 is a common etcd port which folks might be using in their dev machine (if they are playing with etcd separately) and we start the etcd container in host namespace. So just to avoid that case

@mavenugo
Copy link
Contributor

thanks @mrjana . huge 👍 from me. LGTM.

mavenugo added a commit that referenced this pull request Oct 15, 2015
Add etcd integrations tests
@mavenugo mavenugo merged commit cf06fd4 into moby:master Oct 15, 2015
@abronan
Copy link

abronan commented Oct 15, 2015

@mrjana Ok makes sense ;) then you might probably want to change the consul port to something else than 8500 to make sure it does not end up to the state you described.

@mrjana
Copy link
Contributor Author

mrjana commented Oct 15, 2015

@abronan Yeah that makes sense too but since I start consul in bridge network somehow didn't pay attention to the port but we are really mapping container port 8500 to host port 8500. Will do that in another PR. Thanks :-)

@mrjana mrjana deleted the integ branch April 15, 2016 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants