Push driver config during Init
#547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any changes to the remote API in this PR? If so, I don't see any updates to remote.md |
|
@tomdee There are no changes to remote API because of this. |
| return err | ||
| } | ||
| updateDriverConfig(c, i.ntype, config, false) |
There was a problem hiding this comment.
shall we remove this call ? and rather initialize config := make(map[string]interface{}) inside the for.
that makes the code easily readable.
|
@mavenugo Updated to take care of the comments. PTAL |
| } | ||
|
|
||
| for _, i := range initializers { | ||
| if err := i.fn(c, makeDriverConfig(c, i.ntype)); err != nil { |
There was a problem hiding this comment.
Can you please make this change in drivers_windows.go and drivers_freebsd.go as well ?
Currently the driver configuration is pushed through a separate api. This makes driver configuration possible at any arbitrary time. This unncessarily complicates the driver implementation. More importantly the driver does not get access to it's configuration before it can do the handshake with libnetwork. This make the internal drivers a little bit different to external plugins which can get their configuration before the handshake with libnetwork. This PR attempts to fix that mismatch between internal drivers and external plugins. Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
|
@mavenugo Updated again taking care of the comments. PTAL |
|
LGTM |
mavenugo
added a commit
that referenced
this pull request
Sep 19, 2015
Push driver config during `Init`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the driver configuration is pushed through a separate
api. This makes driver configuration possible at any arbitrary
time. This unncessarily complicates the driver implementation.
More importantly the driver does not get access to it's
configuration before it can do the handshake with libnetwork.
This make the internal drivers a little bit different to
external plugins which can get their configuration before the handshake
with libnetwork.
This PR attempts to fix that mismatch between internal drivers and
external plugins.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com