-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for zookeeper backend #462
Conversation
@chenchun thanks for the fix. Can you pls take care of the circleci failure ? |
@chenchun Sorry for the time spent reviewing your PR on libkv's side. Needs a rebase here :( |
@chenchun now that we have the latest libkv, can u pls rebase ? |
@mavenugo , rebased. |
@chenchun CI cannot check against master since it may not be possible to merge without conflict all the time. So it always checks the PR version. That is why in a fast changing project like libnetwork it is always a good idea to rebase to the latest even if github didn't find any merge conflicts. |
@mrjana ok, I see. Even if CI checks against master, PR can still be out dated with new patches merged into master. I'm overthinking. |
@@ -88,3 +88,6 @@ coveralls: | |||
circle-ci: | |||
@${cidocker} make install-deps build-local check-local coveralls | |||
make integration-tests | |||
|
|||
start-services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update the .PHONY
target line above with this target Otherwise it is going to create an empty file calleed start-services
in the root directory.
Signed-off-by: Chun Chen <ramichen@tencent.com>
@chenchun Thanks for taking care of the comments. LGTM |
👍 |
Signed-off-by: Chun Chen ramichen@tencent.com
For both etcd and zookeeper, it's not allowed to watch a not exist node.
Tested on my laptop. Please don't review until docker/libkv#41 get's in.