Remove unused config check #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,6 @@ func newLink(parentIP, childIP string, ports []types.TransportPort, bridge strin | |||
| ports: ports, | |||
| bridge: bridge, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please remove this change when you push again to take care of the test code changes
Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
remove-unused-config-check
branch
from
e083be7
to
f657962
Compare
|
This happened when we moved Thanks for the cleanup. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems redunant:
https://github.com/docker/libnetwork/compare/docker:master...runcom:remove-unused-config-check?expand=1#diff-d7584a11ca25df23d34e42758563aba7L15
ErrIPFwdCfgis not used anymore, the function doesn't depend on the config...The test for
ErrIPFwdCfgis removedSince it's only called checking the config from the outside. Hope it's good :)
Signed-off-by: Antonio Murdaca runcom@linux.com