Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump netlink to 25d2c79 #2304

Closed
wants to merge 2 commits into from
Closed

Conversation

dixudx
Copy link

@dixudx dixudx commented Nov 23, 2018

When I use CGO_ENABLED=1 GOARCH=amd64 GOOS=linux to build the command on Mac,

vendor/github.com/vishvananda/netlink/bpf_linux.go:4:10: fatal error: 'asm/types.h' file not found
#include <asm/types.h>
^~~~~~~~~~~~~
1 error generated.

You need to set CGO_ENABLED=0 to make it work.

This dependency github.com/vishvananda/netlink now eliminates cgo. We don't need to suffer this kind of error any more.

Full diffs:

Current v1.0.0 of github.com/vishvananda/netlink need to update golang.org/x/sys/unix. And we could upgrade that later if needed.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "bump_netlink_1.0.0" git@github.com:dixudx/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@dixudx dixudx force-pushed the bump_netlink_1.0.0 branch 2 times, most recently from 5fc4443 to 4a97a53 Compare November 23, 2018 10:02
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx force-pushed the bump_netlink_1.0.0 branch from 4a97a53 to c537300 Compare November 23, 2018 11:33
@dixudx dixudx force-pushed the bump_netlink_1.0.0 branch from c537300 to 144b737 Compare November 23, 2018 11:34
@dixudx dixudx changed the title bump netlink to 1.0.0 bump netlink to 25d2c79 Nov 23, 2018
Signed-off-by: Di Xu <stephenhsu90@gmail.com>
@dixudx dixudx force-pushed the bump_netlink_1.0.0 branch from 144b737 to a9f364f Compare November 23, 2018 11:37
Copy link
Collaborator

@selansen selansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants