Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add testresult example to readme #995

Merged
merged 2 commits into from
May 22, 2019

Conversation

StefanSchoof
Copy link
Contributor

Adding additional example to the local file export, as discussed in #963

@GordonTheTurtle
Copy link
Collaborator

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "localfileexample" git@github.com:StefanSchoof/buildkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: StefanSchoof <Stefan.Schoof@direkt-gruppe.de>
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks a bit weird to me. First "export test result file" looks very specific. Then, for "--from=builder" I have no idea where this builder image is coming from or what it contains.

Do you just want to say: "To export specific files use multi-stage builds with a scratch stage and copy the needed files into that stage with COPY --from." (you can still have the code example)

Signed-off-by: StefanSchoof <Stefan.Schoof@direkt-gruppe.de>
@StefanSchoof
Copy link
Contributor Author

@tonistiigi thanks for the better text. I changed it in PR.

@tonistiigi tonistiigi merged commit 321197f into moby:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants