-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of linter rules messages #5470
Conversation
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
Some patterns I came up with:
|
8bf8834
to
277b129
Compare
Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
277b129
to
6d26769
Compare
…e-ruleset-messages Signed-off-by: Felipe Santos <felipecassiors@gmail.com>
0a33254
to
7438264
Compare
@felipecrs I think the test cases will also need to be updated. 🙏 |
For sure @thompson-shaun, I will get around to doing it soon. Please leave this on standby until I update it. Sorry. |
No worries! Just wanted to call out in case it got lost in the pile. Thank you for the contribution. Reach out if you need assistance. |
^ |
I will not have time to complete this in the next two weeks. I'll close it to cleanup your backlog and maybe reopen once I'm ready to complete it. |
I spend some time reviewing the messages of these rules, and I found some little inconsistencies in the style. In my opinion this PR improves them.