solver: make digest computation for ops deterministic again #5363
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solver relied on protobuf marshaling to compute a digest. There's no guarantee of the byte order, especially for maps, with marshaling. As an implementation detail, gogo would sort the keys for a map and `Deterministic: true` causes the standard marshaler to sort the keys, but this isn't a reliable method. In the future, we likely want to either remove the maps from the protobuf messages or not rely on protobuf serialization for this function. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solver relied on protobuf marshaling to compute a digest. There's no guarantee of the byte order, especially for maps, with marshaling. As an implementation detail, gogo would sort the keys for a map and
Deterministic: truecauses the standard marshaler to sort the keys, but this isn't a reliable method.In the future, we likely want to either remove the maps from the protobuf messages or not rely on protobuf serialization for this function.