vendor: github.com/pkg/browser v0.0.0-20240102092130-5ac0b6a4141c

[thaJeztah]

It's an indirect dependency of docker/cl; https://github.com/docker/cli/blob/v27.2.0/vendor.mod#L83

full diff: pkg/browser@ce105d0...5ac0b6a

[crazy-max]

https://github.com/docker/cli/blob/v27.2.0/vendor.mod#L83

don't see // indirect on this module, looks like it should be in the top require block?

[crazy-max]

@thompson-shaun Seems area/windows label is wrong, I think we should exclude vendor:

buildkit/.github/labeler.yml

Lines 158 to 161 in 54e43bb

	# area:windows
	area/windows:
	- changed-files:
	- any-glob-to-any-file: "**/*_windows.go"

[thaJeztah]

Interesting output; wondering if we should set things with a different format;

#28 [linux/amd64->darwin/arm64 releaser 4/4] RUN --mount=from=binaries   --mount=source=/tmp/.version,target=/tmp/.version,from=buildkit-version   mkdir -p /out && tar czvf "/out/buildkit-$(cat /tmp/.version).$(echo darwin/arm64 | sed 's/\//-/g').tar.gz" --mtime='2015-10-21 00:00Z' --sort=name --transform 's/^./bin/' .
#28 0.048 tar: Option --mtime: Treating date '2015-10-21 00:00Z' as 2015-10-21 00:00:00

[thaJeztah]

don't see // indirect on this module, looks like it should be in the top require block?

Good catch! Yes it should. I really need to look for ways to catch those; ISTR someone has an action or linter to check for that.

[crazy-max]

Interesting output; wondering if we should set things with a different format;

#28 [linux/amd64->darwin/arm64 releaser 4/4] RUN --mount=from=binaries   --mount=source=/tmp/.version,target=/tmp/.version,from=buildkit-version   mkdir -p /out && tar czvf "/out/buildkit-$(cat /tmp/.version).$(echo darwin/arm64 | sed 's/\//-/g').tar.gz" --mtime='2015-10-21 00:00Z' --sort=name --transform 's/^./bin/' .
#28 0.048 tar: Option --mtime: Treating date '2015-10-21 00:00Z' as 2015-10-21 00:00:00

Ah good catch, seems interpreted in UTC format but seconds are missing when converted. We might need to set TZ=UTC0 or just use 2015-10-21 00:00:00.