migrate to github.com/moby/sys/userns #5224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dependencies
crazy-max
reviewed
Aug 8, 2024
go.mod
Outdated
| @@ -54,6 +54,7 @@ require ( | |||
| github.com/moby/sys/mountinfo v0.7.1 | |||
| github.com/moby/sys/signal v0.7.0 | |||
| github.com/moby/sys/user v0.2.0 | |||
There was a problem hiding this comment.
Oh, yes, we should; dang; thought I did
Commit 4b85f11 migrated the use of the userns package to the github.com/moby/sys/user module. After further discussion with maintainers, it was decided to move the userns package to a separate module, as it has no direct relation with "user" operations (other than having "user" in its name). This patch migrates our code to use the new module. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
migrate_userns
branch
from
c6fd86a
to
b4a1893
Compare
crazy-max
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 4b85f11 migrated the use of the userns package to the github.com/moby/sys/user module.
After further discussion with maintainers, it was decided to move the userns package to a separate module, as it has no direct relation with "user" operations (other than having "user" in its name).
This patch migrates our code to use the new module.