Add gitutil.WithExec(runWithStandardUmask) to Git invocations
#5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes umask bugs while building from a remote Git URL where `ADD`/`COPY`'d files end up with `666`/`777` permissions instead of `644`/`755`. Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
tianon
force-pushed
the
git-checkout-umask
branch
from
5f523f8
to
2448671
Compare
|
I have hand-verified this with the same methodology as in #5066: docker buildx create --name foo --driver-opt image=sha256:of-image-built-from-this-change-to-force-a-local-image
$ docker buildx build --builder foo https://github.com/docker-library/mysql.git#319db566ac7fef45c22f3df15ee5e194a7c43259:8.0 --file Dockerfile.debian --load
...
#16 exporting manifest sha256:549830c9f48b8d7d7579707e8900735dbb688dc8842b264ac8d0d4119a8210bc done
#16 exporting config sha256:11f31906f3b47f2f5380059c1e3072d01491cc4050482c8f4eacd2ba519a6b75 done
...
$ docker run --rm sha256:11f31906f3b47f2f5380059c1e3072d01491cc4050482c8f4eacd2ba519a6b75 ls -l /etc/mysql/my.cnf
-rw-r--r-- 1 root root 1080 Jun 26 23:53 /etc/mysql/my.cnf |
jedevc
previously approved these changes
Jun 27, 2024
|
#5096 looks better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes umask bugs while building from a remote Git URL where
ADD/COPY'd files end up with666/777permissions instead of644/755.Fixes #5066
Refs #4106