lint: fix some testifylint warnings #4932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
testifylint-fixes1
branch
from
b353164 to
4e87d62
Compare
tonistiigi
force-pushed
the
testifylint-fixes1
branch
from
4e87d62 to
fae33ad
Compare
tonistiigi
force-pushed
the
testifylint-fixes1
branch
from
fae33ad to
0e1757f
Compare
|
This one looks legit: https://github.com/moby/buildkit/actions/runs/9289931268/job/25613491736?pr=4932#step:8:2933 |
tonistiigi
force-pushed
the
testifylint-fixes1
branch
from
0e1757f to
c43b9ad
Compare
jsternberg
reviewed
May 30, 2024
| @@ -288,8 +289,8 @@ func TestCacheMountLockedRefs(t *testing.T) { | |||
| gotRef4 := make(chan struct{}) | |||
| go func() { | |||
| ref4, err := g2.getRefCacheDir(ctx, nil, "foo", pb.CacheSharingOpt_LOCKED) | |||
| require.NoError(t, err) | |||
| require.Equal(t, ref.ID(), ref4.ID()) | |||
| assert.NoError(t, err) | |||
There was a problem hiding this comment.
Why is this sometimes changed from assert.NoError to require.NoError and other times it's the opposite? Is this because this is in a goroutine?
There was a problem hiding this comment.
Yes, the rule is that require is not allowed in goroutines, same as https://pkg.go.dev/testing#B.FailNow
| @@ -23,6 +23,7 @@ linters: | |||
| - nolintlint | |||
| - revive | |||
| - staticcheck | |||
| # - testifylint | |||
There was a problem hiding this comment.
Why is this commented out here? Is it just because it doesn't fix everything?
There was a problem hiding this comment.
Yes, this is only the first batch
This does not cover all warning yet but split into chunks to ease review. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
testifylint-fixes1
branch
from
c43b9ad to
03c7a6d
Compare
jsternberg
approved these changes
May 30, 2024
crazy-max
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #4931 (only last commit new)This does not cover all warnings yet but split into chunks to ease review. There are quite a lot of updates needed so we can do them in multiple PRs so that there isn't a big review or bad rebase needed.