dockerfile: detect base image with wrong platform being used #4924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
requested changes
May 16, 2024
tonistiigi
force-pushed
the
baseimage-platform
branch
from
91b90bd to
dbd8208
Compare
jsternberg
approved these changes
May 30, 2024
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
baseimage-platform
branch
from
dbd8208 to
88b2f70
Compare
daghack
approved these changes
May 31, 2024
crazy-max
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the case where the resolved base image does not match the expected platform from request. This can happen in two main cases:
--platformflag).Fixes docker/buildx#844
This isn't directly a linter issue as Dockerfile is not using a wrong command/flag but the base image is problematic. I still used the same naming schema but we probably don't want to include it in the rules docs.