improve alpine version selection per arch #4783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of hardcoding all possible architectures that can be built, define RiscV as exception and any other architecture use $ALPINE_VERSION tag. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
approved these changes
Mar 19, 2024
tonistiigi
commented
Mar 19, 2024
| @@ -22,19 +22,20 @@ ARG ALPINE_VERSION=3.19 | |||
| ARG XX_VERSION=1.4.0 | |||
| ARG BUILDKIT_DEBUG | |||
|
|
|||
| ARG ALPINE_ARCH=${TARGETARCH#riscv64} | |||
There was a problem hiding this comment.
This could be all in one line but probably more readable if split up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding all possible architectures
that can be built, define RiscV as exception and
any other architecture use $ALPINE_VERSION tag.