Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: github.com/containerd/console v1.0.4 #4621

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 5, 2024

Related to docker/buildx#2238 to fix failed to get console mode errors on Windows that has been fixed in containerd/console#66.

@thaJeztah
Copy link
Member

@dmcgowan could we do a new release of containerd/console? Looking at the changes, perhaps we should make that a v1.1.0; there still was some discussion about the removal of solaris support from the repo (having a v1.1.0 would still allow for a v1.0.4 if we really want that).

Perhaps we should do another round of updating Actions, Go, and Golang-CI versions before tagging a release (not critical, but good to have CI verify on current versions of Go I guess)

@thaJeztah
Copy link
Member

@crazy-max v1.0.4 was tagged (same commit)

@crazy-max crazy-max changed the title vendor: github.com/containerd/console 8f6c4e4 vendor: github.com/containerd/console v1.0.4 Feb 5, 2024
full diff: containerd/console@v1.0.3...v1.0.4

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if CI is happy)

@AkihiroSuda AkihiroSuda merged commit 1057dc2 into moby:master Feb 5, 2024
64 checks passed
@crazy-max crazy-max deleted the bump-containerd-console branch February 5, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants