migrate to new github.com/distribution/reference v0.5.0 #4188
Conversation
thaJeztah
force-pushed
the
switch_reference
branch
from
b3ee7b1 to
3275553
Compare
thaJeztah
force-pushed
the
switch_reference
branch
from
3275553 to
83b2314
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
switch_reference
branch
2 times, most recently
from
f1958c5 to
6d766ca
Compare
|
@AkihiroSuda @crazy-max PTAL |
|
Oh! Perhaps I should hold this one until moby/moby#46376 is merged, and update docker/docker vendor in the same PR; looks like we're already using moby/moby "master", so updating it to a version with that patch could potentially "move" the files (instead of adding another copy); Line 31 in 980ea2d Let me temporarily move this back to draft |
|
Should we not wait for distribution v3
Yes was about to say that. Sounds good to me this way. |
Yeah, there's no ETA yet at all for a release of that, so I don't want to wait for that, but at a quick glance, BuildKit only depends on the |
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940 Also updating docker/docker, which also switched to this new module; vendor: github.com/docker/docker 032797ea4bcb (v25.0.0-dev) full diff: moby/moby@afd4805...032797e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
switch_reference
branch
from
6d766ca to
2d3722e
Compare
| # github.com/distribution/reference v0.5.0 | ||
| ## explicit; go 1.20 | ||
| github.com/distribution/reference | ||
| # github.com/docker/cli v24.0.5+incompatible | ||
| ## explicit | ||
| github.com/docker/cli/cli/config | ||
| github.com/docker/cli/cli/config/configfile | ||
| github.com/docker/cli/cli/config/credentials | ||
| github.com/docker/cli/cli/config/types | ||
| github.com/docker/cli/cli/connhelper/commandconn | ||
| # github.com/docker/distribution v2.8.2+incompatible | ||
| ## explicit | ||
| github.com/docker/distribution/digestset | ||
| github.com/docker/distribution/reference | ||
| # github.com/docker/docker v24.0.0-rc.2.0.20230723142919-afd4805278b4+incompatible | ||
| # github.com/docker/docker v24.0.0-rc.2.0.20230905130451-032797ea4bcb+incompatible |
There was a problem hiding this comment.
Alright; github.com/docker/distribution is gone now from the vendor. 🎉
|
@crazy-max included the updated docker/docker, and moved it out of draft; this one should be ready for review 👍 |
|
@tonistiigi PTAL 🤗 |
There was a problem hiding this comment.
(Wondering if we can instruct go mod vendor to ignore this file)
There was a problem hiding this comment.
don't think so, but it's definitely an odd choice to consider "SVG" files to be an essential part of go modules
The "reference" package was moved to a separate module, which was extracted from distribution/distribution@b9b1940
Also updating docker/docker, which also switched to this new module;
vendor: github.com/docker/docker 032797ea4bcb (v25.0.0-dev)
full diff: moby/moby@afd4805...032797e