Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.12] v0.12.2 cherry-picks #4169

Merged
merged 3 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions docs/annotations.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,12 @@ write to the following `<type>`s:
- The `manifest` (the default, as above)
- The `manifest-descriptor`
- This adds the annotation into the image index's descriptor for the manifest
- (discarded if the output does not contain an image index)
- The `index`
- This adds the annotation into the image index root
- (discarded if the output does not contain an image index)
- If the exporter does not produce an image index, the build will fail.
- The `index-descriptor`
- This adds the annotation into the OCI layout's descriptor for the index
- (discarded if the output does not contain an OCI layout)
- If the exporter does not produce an image index, the build will fail.

For example, if you want to add the annotation at the image index level, so
that the annotation is shared between all architectures, you can instead:
Expand Down
2 changes: 1 addition & 1 deletion docs/buildkitd.toml.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ insecure-entitlements = [ "network.host", "security.insecure" ]

[[worker.oci.gcpolicy]]
# keepBytes can be an integer number of bytes (e.g. 512000000), a string
# with a unit (e.g. "512MB"), or a string percentage of available disk
# with a unit (e.g. "512MB"), or a string percentage of the total disk
# space (e.g. "10%")
keepBytes = "512MB"
# keepDuration can be an integer number of seconds (e.g. 172800), or a
Expand Down
2 changes: 1 addition & 1 deletion util/progress/multiwriter.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func (ps *MultiWriter) Write(id string, v interface{}) error {
Sys: v,
meta: ps.meta,
}
return ps.WriteRawProgress(p)
return ps.writeRawProgress(p)
}

func (ps *MultiWriter) WriteRawProgress(p *Progress) error {
Expand Down
Loading