Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.11 backport] azblob and s3 integration tests #4030

Merged
merged 7 commits into from
Jul 20, 2023
Merged

[0.11 backport] azblob and s3 integration tests #4030

merged 7 commits into from
Jul 20, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jul 17, 2023 •
edited
Loading

@crazy-max
integration: expose backend logs in sandbox interface
df006bc 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 3d93d64)
@crazy-max
integration: add runCmd and randomString utils
c53338e 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit c03ccb8)
@crazy-max
integration: basic s3 cache test
2381fe1 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 35e870d)
@crazy-max
hack: remove s3_test
2b9caf7 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 05c4d57)
@crazy-max
integration: basic azblob cache test
a31b349 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 54695a3)
@crazy-max
hack: remove azblob_test
e870615 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 2f8b5e7)
@thaJeztah thaJeztah mentioned this pull request Jul 17, 2023
Merged
1 task
@thaJeztah
Copy link
Member

Looks like some failures; do we know what's causing them?

@thaJeztah thaJeztah mentioned this pull request Jul 19, 2023
Merged
2 tasks
@crazy-max crazy-max mentioned this pull request Jul 20, 2023
Merged
@crazy-max
Copy link
Member Author

Oh didn't catch this, I will take a look

=== CONT  TestIntegration/TestBasicAzblobCacheImportExport/worker=containerd
    client_test.go:4640: 
        	Error Trace:	/src/client/client_test.go:4640
        	            				/src/client/client_test.go:4810
        	            				/src/client/run.go:88
        	            				/src/client/run.go:197
        	Error:      	Received unexpected error:
        	            	failed to configure azblob cache exporter: failed to create container client: failed to get properties of cache container cachecontainer: ===== RESPONSE ERROR (ErrorCode=AuthorizationFailure) =====
        	            	Description=Server failed to authenticate the request. Make sure the value of the Authorization header is formed correctly including the signature.
        	            	RequestId:9ad55995-0f94-4ebb-96ea-8a6816ebd3f9
        	            	Time:2023-07-17T13:10:02.179Z, Details: (none)
        	            	
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:77
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:197
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).Solve
        	            		/src/api/services/control/control.pb.go:2208
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:258
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1594
        	            	failed to solve
        	            	github.com/moby/buildkit/client.(*Client).solve.func2
        	            		/src/client/solve.go:273
        	            	golang.org/x/sync/errgroup.(*Group).Go.func1
        	            		/src/vendor/golang.org/x/sync/errgroup/errgroup.go:75
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1594
        	Test:       	TestIntegration/TestBasicAzblobCacheImportExport/worker=containerd

@crazy-max
azblob cache: account_name attribute
1ace6ac 
By default account name is parsed from request uri host (account url)
but when product style url is disabled, account name is not part of the
host. This new attribute allows to specify the account name in such case.

Also return error if account name is empty.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review July 20, 2023 18:49
@crazy-max crazy-max added this to the v0.11.7 milestone Jul 20, 2023
thaJeztah
thaJeztah approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, nice!

"LGTM" (because CI is green, not because I know anything about these changes 🙈)

@crazy-max crazy-max merged commit 1a7e065 into moby:v0.11 Jul 20, 2023
41 checks passed
@crazy-max crazy-max deleted the v0.11_backport_test-azblob-minio branch July 20, 2023 21:12
@crazy-max crazy-max mentioned this pull request Jul 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@jedevc jedevc Awaiting requested review from jedevc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.7
Development

Successfully merging this pull request may close these issues.
2 participants
@crazy-max @thaJeztah