-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testutil: pin busybox and alpine used in releases #3469
Conversation
5aa49a9
to
1e556da
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
1e556da
to
2f48f16
Compare
Still failing https://github.com/moby/buildkit/actions/runs/3858054800/jobs/6576171616
|
"amd64": "sha256:c0d488a800e4127c334ad20d61d7bc21b4097540327217dfab52262adc02380c", | ||
"arm64v8": "sha256:af06af3514c44a964d3b905b498cf6493db8f1cde7c10e078213a89c87308ba0", | ||
"library": "sha256:8914eb54f968791faf6a8638949e480fef81e697984fba772b3976835194c6d4", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use the digest of the multi-platform index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iirc this was optimization in amd64/arm64 to avoid mirroring the unneeded architectures. Other arch use library
ns with multi-platform.
package integration | ||
|
||
var pins = map[string]map[string]string{ | ||
// busybox is pinned to 1.35. Newer produces has "illegal instruction" panic on some of Github infra on sha256sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this issue tracked somewhere?
Can't find a ticket in https://github.com/docker-library/busybox/issues and https://bugs.busybox.net/buglist.cgi?chfield=%5BBug%20creation%5D&chfieldfrom=30 .
Seems related to mirror/busybox@6472ac9 though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reported to busybox yet. If you do, you can post this debug: https://github.com/tonistiigi/gh-busybox-sigill-debug/actions/runs/3858482123
Good CPUs: 8370C, E5-2673
Bad CPUs: 8171M, 8272CL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaces #3464
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com