Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutil: pin busybox and alpine used in releases #3469

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

tonistiigi
Copy link
Member

replaces #3464

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
Copy link
Member

Still failing https://github.com/moby/buildkit/actions/runs/3858054800/jobs/6576171616

#5 [build 1/3] FROM docker.io/library/busybox@sha256:7b3ccabffc97de872a30dfd234fd972a66d247c8cfc69b0550f276481852627c
#5 resolve docker.io/library/busybox@sha256:7b3ccabffc97de872a30dfd234fd972a66d247c8cfc69b0550f276481852627c done
#5 sha256:205dae5015e78dd8c4d302e3db4eb31576fac715b46d099fe09680ba28093a7a 2.59MB / 2.59MB 0.1s done
#5 extracting sha256:205dae5015e78dd8c4d302e3db4eb31576fac715b46d099fe09680ba28093a7a 0.1s done
#5 DONE 0.2s

#6 [build 2/3] RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first
#6 0.479 Illegal instruction (core dumped)
time="2023-01-06T19:56:23Z" level=error msg="/moby.buildkit.v1.Control/Solve returned error: rpc error: code = Unknown desc = process \"/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first\" did not complete successfully: exit code: 132"
#6 ERROR: process "/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first" did not complete successfully: exit code: 132
------
 > [build 2/3] RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first:
#6 0.479 Illegal instruction (core dumped)
------
Dockerfile:2
--------------------
   1 |     FROM busybox AS build
   2 | >>> RUN cat /dev/urandom | head -c 100 | sha256sum > unique_first
   3 |     RUN cat /dev/urandom | head -c 100 | sha256sum > unique_second
   4 |     
--------------------
error: failed to solve: process "/bin/sh -c cat /dev/urandom | head -c 100 | sha256sum > unique_first" did not complete successfully: exit code: 132

"amd64": "sha256:c0d488a800e4127c334ad20d61d7bc21b4097540327217dfab52262adc02380c",
"arm64v8": "sha256:af06af3514c44a964d3b905b498cf6493db8f1cde7c10e078213a89c87308ba0",
"library": "sha256:8914eb54f968791faf6a8638949e480fef81e697984fba772b3976835194c6d4",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use the digest of the multi-platform index?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc this was optimization in amd64/arm64 to avoid mirroring the unneeded architectures. Other arch use library ns with multi-platform.

package integration

var pins = map[string]map[string]string{
// busybox is pinned to 1.35. Newer produces has "illegal instruction" panic on some of Github infra on sha256sum
Copy link
Member

@AkihiroSuda AkihiroSuda Jan 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reported to busybox yet. If you do, you can post this debug: https://github.com/tonistiigi/gh-busybox-sigill-debug/actions/runs/3858482123

Good CPUs: 8370C, E5-2673
Bad CPUs: 8171M, 8272CL

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants