Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v0.10 backport] control: add info service #3145

Closed
wants to merge 2 commits into from
Closed

[v0.10 backport] control: add info service #3145

wants to merge 2 commits into from

Conversation

thaJeztah
Copy link
Member

Minor conflict in worker/workercontroller.go, due to #2850 being cherry-picked already in #2851

@crazy-max @thaJeztah
control: add info service
fa1611c 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit 859ad49)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@crazy-max @thaJeztah
control: add buildkit version to worker record
beef954 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
(cherry picked from commit d2a757f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Failure seems unrelated;

--- FAIL: TestCacheMountLockedRefs (14.57s)
    mount_test.go:327: 
        	Error Trace:	mount_test.go:327
        	Error:      	mount did not unlock
        	Test:       	TestCacheMountLockedRefs
FAIL
coverage: 36.3% of statements
FAIL	github.com/moby/buildkit/solver/llbsolver/mounts	36.794s

@thaJeztah thaJeztah marked this pull request as ready for review October 4, 2022 11:45
@thaJeztah
Copy link
Member Author

@crazy-max @tonistiigi PTAL; I know there was some discussion around this (as moby 22.06 wanted to provide this), and I ran into this patch when trying to backport #3101 to make Moby CI happy, so thought I'd open a cherry-pick for consideration.

@thaJeztah thaJeztah mentioned this pull request Oct 4, 2022
Closed
@thaJeztah
Copy link
Member Author

Discussing with @crazy-max and we probably won't be back porting this (but if possible have a v0.11); moving back to draft

@thaJeztah thaJeztah marked this pull request as draft October 4, 2022 16:13
@tonistiigi tonistiigi closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @tonistiigi @crazy-max