solver: correct cache nil return value in Exec #3066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3043.
We introduce a new boolean
execDone
to track whether we've successfully completed anExec
call in the past, sincenil
is a possible return value fromExec
.We have some similar logic for
cacheDone
set byCacheMap
, hence the name of the new bool, but I wonder if we might want to handlenil
return values for that as well? Not sure if that would ever trigger, and also not super familiar with the logic here 👀buildkit/solver/jobs.go
Lines 747 to 752 in c58f128