executor/oci: replace deprecated types.IP #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering why the linter didn't complain about this use of a deprecated type 🤔 |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
replace_deprecated
branch
from
b3349be to
dfb08e3
Compare
|
@crazy-max PTAL |
|
Perhaps worth cherry-picking this if we do another patch release, as it removes an (otherwise unused) dependency |
AkihiroSuda
approved these changes
May 11, 2022
crazy-max
approved these changes
May 11, 2022
|
@AkihiroSuda Why did you mark this cherry-pick? |
|
Probably #2858 (comment) But let me know if you see an issue with that (local changes is just a one line change) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remaining changes from #2317