examples/dockerfile2llb: add --partial-image-config-file, --partial-metadata-file
#2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
tonistiigi
reviewed
Apr 10, 2022
There was a problem hiding this comment.
This is somewhat confusing as these are not the types that buildctl or docker buildx would write, but the inputs to the actual build. The image config in here only contains partial rootfs and buildinfo only has sources for the tags that Dockerfile frontend replaced before generating LLB. In actual build result metadata there would be more BuildInfo fields.
examples/dockerfile2llb/main.go
Outdated
| var opt buildOpt | ||
| flag.StringVar(&opt.target, "target", "", "target stage") | ||
| flag.StringVar(&opt.imageJSONFile, "image-json-file", "", "Output image config to a file as JSON") |
There was a problem hiding this comment.
image-config-file maybe as JSON could be manifest as well.
…etadata-file Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
examples-dockefile2llb-metadata
branch
from
24249f3 to
1a56835
Compare
AkihiroSuda
changed the title
--image-json-file, --metadata-file--partial-image-config-file, --partial-metadata-file
|
Changed the flag names to |
tonistiigi
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildkit/frontend/dockerfile/dockerfile2llb/convert.go
Line 73 in 86c33b6
The stdout is for
*llb.State,--partial-image-config-fileis for*Image,--partial-metadata-fileis for*binfotypes.BuildInfo.The
*binfotypes.BuildInfocontains source information fordocker-imagebut does not contain other source information such ashttp.