Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: make sure local cache import is propagated via gateway API #2659

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

tonistiigi
Copy link
Member

fixes #2599

Currently the local cache import only worked with client.Solve
function.

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

Currently the local cache import only worked with client.Solve
function.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerhard
Copy link

gerhard commented Feb 28, 2022

It was so great to come back to this! Great job @TomChv for finding the fix 🙌🏻

Thank you @tonistiigi @crazy-max for getting v0.10.0-rc.2 out so promptly 🚀 - it includes this fix.

The next step is on our side: bump buildkit to v0.10.0-rc.2:
https://github.com/dagger/dagger/blob/bfd15f0abed0dc1b52360b049c9c6497a1d2217b/go.mod#L23

cc @aluzzardi @TomChv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local cache error/unused with Buildkit go client
3 participants