-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example: build-using-dockerfile #223
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,157 @@ | ||
package main | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"io/ioutil" | ||
"os" | ||
"os/exec" | ||
"path/filepath" | ||
"strings" | ||
|
||
"github.com/containerd/console" | ||
"github.com/moby/buildkit/client" | ||
"github.com/moby/buildkit/util/appcontext" | ||
"github.com/moby/buildkit/util/appdefaults" | ||
"github.com/moby/buildkit/util/progress/progressui" | ||
"github.com/pkg/errors" | ||
"github.com/sirupsen/logrus" | ||
"github.com/urfave/cli" | ||
"golang.org/x/sync/errgroup" | ||
) | ||
|
||
func main() { | ||
app := cli.NewApp() | ||
app.Name = "build-using-dockerfile" | ||
app.UsageText = `build-using-dockerfile [OPTIONS] PATH | URL | -` | ||
app.Description = ` | ||
build using Dockerfile. | ||
|
||
This command mimics behavior of "docker build" command so that people can easily get started with BuildKit. | ||
This command is NOT the replacement of "docker build", and should NOT be used for building production images. | ||
|
||
By default, the built image is loaded to Docker. | ||
` | ||
dockerIncompatibleFlags := []cli.Flag{ | ||
cli.StringFlag{ | ||
Name: "buildkit-addr", | ||
Usage: "buildkit daemon address", | ||
EnvVar: "BUILDKIT_HOST", | ||
Value: appdefaults.Address, | ||
}, | ||
} | ||
app.Flags = append([]cli.Flag{ | ||
cli.StringSliceFlag{ | ||
Name: "build-arg", | ||
Usage: "Set build-time variables", | ||
}, | ||
cli.StringFlag{ | ||
Name: "file, f", | ||
Usage: "Name of the Dockerfile (Default is 'PATH/Dockerfile')", | ||
}, | ||
cli.StringFlag{ | ||
Name: "tag, t", | ||
Usage: "Name and optionally a tag in the 'name:tag' format", | ||
}, | ||
cli.StringFlag{ | ||
Name: "target", | ||
Usage: "Set the target build stage to build.", | ||
}, | ||
}, dockerIncompatibleFlags...) | ||
app.Action = action | ||
if err := app.Run(os.Args); err != nil { | ||
fmt.Fprintf(os.Stderr, "error: %v\n", err) | ||
os.Exit(1) | ||
} | ||
} | ||
|
||
func action(clicontext *cli.Context) error { | ||
if tag := clicontext.String("tag"); tag == "" { | ||
return errors.New("tag is not specified") | ||
} | ||
c, err := client.New(clicontext.String("buildkit-addr"), client.WithBlock()) | ||
if err != nil { | ||
return err | ||
} | ||
tmpTar, err := ioutil.TempFile("", "buldkit-build-using-dockerfile") | ||
if err != nil { | ||
return err | ||
} | ||
defer os.Remove(tmpTar.Name()) | ||
solveOpt, err := newSolveOpt(clicontext, tmpTar.Name()) | ||
if err != nil { | ||
return err | ||
} | ||
ch := make(chan *client.SolveStatus) | ||
eg, ctx := errgroup.WithContext(appcontext.Context()) | ||
eg.Go(func() error { | ||
return c.Solve(ctx, nil, *solveOpt, ch) | ||
}) | ||
eg.Go(func() error { | ||
if c, err := console.ConsoleFromFile(os.Stderr); err == nil { | ||
// not using shared context to not disrupt display but let is finish reporting errors | ||
return progressui.DisplaySolveStatus(context.TODO(), c, ch) | ||
} | ||
return nil | ||
}) | ||
if err := eg.Wait(); err != nil { | ||
return err | ||
} | ||
logrus.Infof("Loading the image to Docker as %q. This may take a while.", clicontext.String("tag")) | ||
if err := loadDockerTar(tmpTar.Name()); err != nil { | ||
return err | ||
} | ||
logrus.Info("Done") | ||
return nil | ||
} | ||
|
||
func newSolveOpt(clicontext *cli.Context, tmpTar string) (*client.SolveOpt, error) { | ||
buildCtx := clicontext.Args().First() | ||
if buildCtx == "" { | ||
return nil, errors.New("please specify build context (e.g. \".\" for the current directory)") | ||
} else if buildCtx == "-" { | ||
return nil, errors.New("stdin not supported yet") | ||
} | ||
|
||
file := clicontext.String("file") | ||
if file == "" { | ||
file = filepath.Join(buildCtx, "Dockerfile") | ||
} | ||
localDirs := map[string]string{ | ||
"context": buildCtx, | ||
"dockerfile": filepath.Dir(file), | ||
} | ||
|
||
frontendAttrs := map[string]string{ | ||
"filename": filepath.Base(file), | ||
} | ||
if target := clicontext.String("target"); target != "" { | ||
frontendAttrs["target"] = target | ||
} | ||
|
||
for _, buildArg := range clicontext.StringSlice("build-arg") { | ||
kv := strings.SplitN(buildArg, "=", 2) | ||
if len(kv) != 2 { | ||
return nil, errors.Errorf("invalid build-arg value %s", buildArg) | ||
} | ||
frontendAttrs["build-arg:"+kv[0]] = kv[1] | ||
} | ||
return &client.SolveOpt{ | ||
Exporter: "docker", // TODO: use containerd image store when it is integrated to Docker | ||
ExporterAttrs: map[string]string{ | ||
"name": clicontext.String("tag"), | ||
"output": tmpTar, | ||
}, | ||
LocalDirs: localDirs, | ||
Frontend: "dockerfile.v0", // TODO: use gateway | ||
FrontendAttrs: frontendAttrs, | ||
}, nil | ||
} | ||
|
||
func loadDockerTar(tar string) error { | ||
// no need to use moby/moby/client here | ||
cmd := exec.Command("docker", "load", "-i", tar) | ||
cmd.Stdout = os.Stdout | ||
cmd.Stderr = os.Stderr | ||
return cmd.Run() | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a required value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is just required for exportation.
We can remove it later.