add retry handlers to push/pull #1791
Merged
+99
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
AkihiroSuda
approved these changes
Nov 14, 2020
cache/remote.go
Outdated
| return func(dt []byte) { | ||
| pw, _, _ := progress.FromContext(ctx) | ||
| pw.Write(identity.NewID(), client.VertexLog{ | ||
| Stream: 2, |
There was a problem hiding this comment.
Can we have const for this magic value
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
push-pull-retry
branch
from
ca42836 to
cf8babd
Compare
AkihiroSuda
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike docker, containerd does not perform retries on dropped connections. This adds basic retry backoff mechanisms for certain errors while logging them instead. Note that chunk based resume is still missing on push.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com