Fix race in CNI namespaces #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
tonistiigi
reviewed
Nov 2, 2020
Signed-off-by: Vlad A. Ionescu <vladaionescu@users.noreply.github.com>
tonistiigi
approved these changes
Nov 2, 2020
tiborvass
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing the file
nativeID, we were removing the dir containing allnativeIDs. This was causing a race between theMkdirAlltrying to create thecnidir and anynativeIDs being removed, where the entirecnidir was wiped.The errors looked cryptic:
failed to mount: no such file or directoryand was only showing up in highly-parallel buildkit-in-buildkit situations (like in Earthly's integration tests).