chore: added log for null hierarchy #2217
Open
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanjeetsingh150
approved these changes
Dec 24, 2024
|
Let's also add logs on ViewHierarchyHandler and update driver. |
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
| @@ -118,11 +122,17 @@ struct ViewHierarchyHandler: HTTPHandler { | |||
| } | |||
|
|
|||
| let alerts = logger.measure(message: "Fetch alert hierarchy") { | |||
| fullScreenAlertHierarchy(element) | |||
| fullScreenAlertHierarchy(element) { | |||
There was a problem hiding this comment.
Is this call taking a function argument? I don't think this will compile can you try executing:
sh maestro-ios-xctest-runner/build-maestro-ios-runner.sh
Let's actually add a log on line 40 and 42 before we return because in case the endpoint returns error we would have the logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is null hierarchy,
val error = mapper.readValue(responseBodyAsString, Error::class.java)fails, and we don't get the status code and error message. Added a warn log before it so that we can know the status code and error message.