fix: don't allow negative swipe duration #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure to run ./maestro-ios-xctest-runner/build-maestro-ios-runner.sh with every swift change |
axelniklasson
commented
Oct 2, 2024
| element: | ||
| id: "maestro" | ||
| direction: DOWN | ||
| speed: 110 |
There was a problem hiding this comment.
Setting speed > 100 yields a negative duration so this is intended
There was a problem hiding this comment.
Hmmm, might be some change that we have setting on duration for this maestro release.
I believe this one:
There was a problem hiding this comment.
Yes that is suspicious but I couldn't figure out how this would yield a negative duration without setting the speed in a flow.
igorsmotto
approved these changes
Oct 2, 2024
| @@ -3135,6 +3135,42 @@ class IntegrationTest { | |||
| ) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `Case 118 - Scroll until view is visible - no negative values allowed`() { | |||
amanjeetsingh150
approved these changes
Oct 3, 2024
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
* fix: don't allow negative swipe duration * update ios driver
rasyid7
pushed a commit
to rasyid7/maestro
that referenced
this pull request
Dec 9, 2024
* fix: don't allow negative swipe duration * update ios driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.