Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq. IDs → alphanumeric hashes; embedding broken #2

Closed
jm3 opened this issue Oct 3, 2018 · 1 comment · Fixed by #3
Closed

seq. IDs → alphanumeric hashes; embedding broken #2

jm3 opened this issue Oct 3, 2018 · 1 comment · Fixed by #3
Labels
Milestone

Comments

@jm3
Copy link

jm3 commented Oct 3, 2018

looks like Asciinema switched to ASCII hashes / chunk IDs instead of sequential numeric IDs, which jekyll-asciinema doesn't seem to like:

% ruby --version
ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-darwin16]

% bundle list | grep ascii
  * jekyll-asciinema (0.2.0)

... foo.md:
{% asciicast 'lMotMSXHCbqpgIxcBse0BOsPU' %}

...jekyll: 
Liquid Exception: Syntax error in tag 'asciicast' while parsing the following markup:
  'lMotMSXHCbqpgIxcBse0BOsPU' Valid syntax: {% asciicast 123456 %} in 
  ~jm3/sites/blog.jm3.net/_posts/2018/10-02-asciinema.md

I tried with and without quotes; let me know if I'm missing something.

FWIW, the actual embed markup to be generated (linked above) is unchanged; the plugin just needs to pass them through like the numeric IDs — i.e., this works:

<script
  src="https://asciinema.org/a/lMotMSXHCbqpgIxcBse0BOsPU.js"
  id="asciicast-lMotMSXHCbqpgIxcBse0BOsPU" async></script>
@jm3 jm3 changed the title hashes instead of seq. IDs' — plugin generating non-working embed markup seq. IDs → alphanumeric hashes; embedding broken Oct 3, 2018
mnuessler added a commit that referenced this issue Nov 21, 2021
@mnuessler mnuessler added the bug label Nov 21, 2021
@mnuessler mnuessler added this to the v0.2.1 milestone Nov 21, 2021
@mnuessler
Copy link
Owner

Thanks a lot for taking the time to report the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants