ENH: code to handle QR special text #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Generate the QrSpecial-derived e-mail address. | ||
|
|
||
| Args: | ||
| url (str|unicode): The e-mail address. |
Fixed URL to support more protocols. The documentation should be fixed now.
|
Thanks for spotting that, it should be fixed now :-) |
|
I actually believe it shoul be modified again, as url should be the first argument of the constructor |
inverted 'url' and 'protocol' in QrUrl.__init__ signature
|
Done. |
This was referenced May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this project may benefit from handling QR special text, as commonly accepted by other QR implementation, e.g. ZXing.
This code should correctly handle: QrPhone, QrEmail, QrMessage, QrGeolocation, QrUrl, QrContact (MeCard), QrWifi.
It is meant to run unmodified on both Python2 and Python3 identically.
I have copy-pasted some code that I have written for myself, so apologies if the docstrings may not comply to what you usually use. Feel free to modify to fit your project better.
I have also adapted the copyright notice to comply with yours.