Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pool_timeout param usage #81

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

patchkord
Copy link
Contributor

@patchkord patchkord commented Apr 21, 2023

This MR fix the pool_timeout parameter usage from a config.

poolboy:checkout function has arity 2/3 there the second argument is not a timeout.
The second argument allows to block and wait a free worker.

@patchkord patchkord changed the title fix the pool_timeout param usage Fix the pool_timeout param usage Apr 21, 2023
@mneudert mneudert changed the base branch from master to v2.2 April 22, 2023 10:15
@mneudert mneudert force-pushed the fix_pool_timeout_usage branch from 95733cb to 9a82654 Compare April 22, 2023 10:27
@coveralls
Copy link

coveralls commented Apr 22, 2023

Coverage Status

Coverage: 76.008% (-4.9%) from 80.892% when pulling 9a82654 on dessel:fix_pool_timeout_usage into 507c586 on mneudert:v2.2.

@mneudert mneudert merged commit d9ef6be into mneudert:v2.2 Apr 22, 2023
@mneudert
Copy link
Owner

❤️ 💚 💜 💙 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants