-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include MNE-ICALabel (and PyTorch) in the Windows installers #168
Conversation
If we merge this, please don't squash the history – I separated the commits so it'll be easier to compile the changelog. |
Dependency resolution seems to work; however, installer creation on Windows fails for unknown reasons :( |
@larsoner Have we seen such an issue before? I'm not sure |
No, I'm guessing it's unrelated to this PR (and probably due to conda installer updates) but it's worth checking |
Okay on mamba 1.1.0 / 87f96bf the failure is:
Going to try reverting our NSIS hotfix to see if that helps... |
@larsoner Failing :(
|
@jaimergp our https://github.com/mne-tools/mne-installers/actions/runs/4166630449/jobs/7211209939
And switching to https://github.com/mne-tools/mne-installers/actions/runs/4169356013/jobs/7217229034
Any ideas here? |
Maybe try running |
3e46126
to
c9836b0
Compare
TL;DR: Thanks to your help @jaimergp, it looks like the problem is that something new we add here (PyTorch) makes the installers too big (>2GB I guess?) which is problematic. Verbose mode was informative in e07c9d3 / CI:
Although it says it successfully created the file (?), it appears not to have done so as our simple filename glob fails:
After a bit of googling it sounded like we might be hitting a 2GB limitation of NSIS. I suspected PyTorch adds a lot of code, so I removed |
OUCH @larsoner Let's try without Spyder, WDYT? |
I don't think we should drop Spyder for PyTorch on Windows |
My idea was that maybe we could create two separate installers, one with more basic functionality and including Spyder, and one for more advanced users |
I think I'd rather just give the advanced users the instructions for how to get PyTorch installed on Windows |
There is a project that removes the 2 GB limitation, but I have no clue how we could make use if it in constructor https://sourceforge.net/projects/nsisbi/ @jaimergp WDYT? |
Great find! I'll open an issue on |
No description provided.