Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix CIs #164

Merged
merged 6 commits into from
Dec 15, 2023
Merged

[CI] Fix CIs #164

merged 6 commits into from
Dec 15, 2023

Conversation

adam2392
Copy link
Member

Thanks for contributing. If this is your first time,
make sure to read contributing.md

PR Description

Describe your PR here

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Member Author

This will fix the CI issues in #163

cc: @tsbinns and @orabe

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Copy link
Member Author

There is just one circleCI failure related to getting dipy sphinx objects imported.

Otw, this is good for review/approval

@larsoner
Copy link
Member

Looks like you need to update the URL to https://docs.dipy.org/1.8.0

Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit 32b10ea into mne-tools:main Dec 15, 2023
7 of 9 checks passed
@adam2392 adam2392 deleted the fixci branch December 15, 2023 18:25
@tsbinns
Copy link
Collaborator

tsbinns commented Dec 15, 2023

Brilliant, thanks @adam2392!

larsoner added a commit to larsoner/mne-connectivity that referenced this pull request Jan 9, 2024
* upstream/main: (56 commits)
  [CI] Fix CIs (mne-tools#164)
  Fix azure
  Fix CIs
  New dev for v0.7
  [RELEASE] V0.6 (mne-tools#162)
  Try azure again
  [CI] Fix azure (mne-tools#161)
  Add gitblame
  [MAINT] Run black, isort, ruff, and other auto-linters on entire package (mne-tools#159)
  [MAINT] Replace setup.py with pyproject.toml (mne-tools#160)
  [BUG] Fixed issue w/ different rank-indices length (mne-tools#158)
  [MAINT] Refactor bivariate and multivariate methods into separate files (mne-tools#156)
  [MAINT] Fix failing unit tests & update CI packages (mne-tools#157)
  fixed grammar mistake
  switched to array indices & added inline comments
  updated default non-zero rank tolerance
  removed redundant list creation
  removed redundant ignored word
  switched to masked indices for multivariate conn
  updated time
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants