MAINT: Cleaner traceback on error #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Error is unrelated but I'll investigate to see if I can figure out where it's coming from. Probably a |
larsoner
commented
May 20, 2024
| @@ -1,9 +1,10 @@ | |||
| {# Modified from https://github.com/mkdocstrings/python/blob/master/src/mkdocstrings_handlers/python/templates/material/_base/attribute.html #} | |||
| {# Updated 2024/05/20. See "START NEW CODE" for block that is new. #} | |||
There was a problem hiding this comment.
So the real necessary change here was to git mv the file. But while I was at it I also took the latest version from the URL above. We'll see if it renders okay. If not we can revert
|
Comparing:
I think things look okay, so ready for review/merge from my end @hoechenberger ! |
larsoner
commented
May 28, 2024
| title=f"{kind} cleaning", | ||
| caption=caption, | ||
| section=title, | ||
| tags=tags, | ||
| replace=True, | ||
| ) | ||
| plt.close(fig) |
There was a problem hiding this comment.
Need this one for green CIs and this PR is pretty trivial I think, so I'll go ahead and merge. Happy to make changes if you see issues though @hoechenberger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for changelog update I think, just shortens the traceback and fails faster when
cross_val_scorefails for CSP just like it does for other decoding types.