-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging output when rejecting epochs; and log number of reconstructed ICA and SSP epochs #936
Conversation
Same failure on three CIs @hoechenberger You know how to raise this as an issue with the OpenNeuro folks? |
Yes I can take care of this tomorrow! Any input on this PR content? It's not DRY at all, but I'm also not convinced that adding yet another helper function would be beneficial – the pipeline complexity is already too much for me sometimes :( |
Looks reasonable to me so far. I don't see a convincingly cleaner way to make it more DRY anyway |
@larsoner I marked this for auto-merge, I hope this is okay with you! Otherwise feel free to let me know and I can revert. |
@larsoner Tracking the OpenNeuro issue at OpenNeuroOrg/openneuro#3033 |
Pull Request is not mergeable
Failure is just downloading 246 and I can't imagine that would fail given the others passed with these changes so I'll merge, thanks @hoechenberger ! |
quite some duplication … but Logging is better
Before merging …
docs/source/changes.md
)